| Re: [jakartaee-examples-dev] Pull Request Submitted |
|
I think overall it looks good! It appears that there may be an issue with your email address associated with the GitHub pull request and your Eclipse contributors agreement (based on the automatic check in the PR). https://accounts.eclipse.org/legal/eca/validation/34076
I am curious what other hooks exist for PR's in this GitHub repo,
like any type of CI/CD that runs for PR's (if even just running tests). Does anyone have access to the repo settings?
Maybe a next step is to elect/choose repo maintainer(s) so that we can get PR's approved and Manfred can relax on the beach now that he has retired
🙂
Cheers,
Jason Pollard
From: jakartaee-examples-dev-bounces@xxxxxxxxxxx <jakartaee-examples-dev-bounces@xxxxxxxxxxx> on behalf of omniprof@xxxxxxxxx <omniprof@xxxxxxxxx>
Sent: Wednesday, April 29, 2020 3:45 PM To: jakartaee-examples-dev@xxxxxxxxxxx <jakartaee-examples-dev@xxxxxxxxxxx> Subject: [jakartaee-examples-dev] Pull Request Submitted Hi,
I have just submitted a pull request, my first ever, for jakartaee-examples. It consists of The Learning Servlet along with a minor error correction to the parent pom file. As requested it is in the same style as all other individual projects and does not use any external libraries. There is a simple test that deploys the web site and then clicks on a button to execute the servlet.
Feel free to make any suggestions or criticisms. I hope to submit more especially as I have figured out how to do it, finally.
Ken Fogel
|
