Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [incubation] Question about third party code contribution

For contributions from a non-committer larger than 1000 lines of code you
need to file a CQ attaching the contributed patch (I usually use git format-patch
and attach the result). Also link corresponding bug and Gerrit change or Github pull request
which is in review. Any of the project's committers can file the CQ. Only submit the change
when the CQ is resolved with an approval.

See figure 12 on page 1 of
which leads to figure 6 on page 3 of the same poster


´╗┐On 10.02.18, 00:08, "incubation-bounces@xxxxxxxxxxx on behalf of Jeen Broekstra" <incubation-bounces@xxxxxxxxxxx on behalf of jeen.broekstra@xxxxxxxxx> wrote:

    We have received a sizable code contribution from a non-committer to our 
    project (Eclipse RDF4J). The contribution is a whole new functional 
    module, and comprises roughly 1,500 lines of code.
    There's an open Pull Request for it at .
    This is first time we've dealt with this so I just want to be sure I 
    understand what steps need to be taken. Do I understand correctly that 
    with a contribution this size, simply having the contributor sign the 
    CLA is not enough?
    I had a look at the outlined procedure in the Project Handbook 
    (, judging 
    from the diagram there our case falls under figure 3: "Written 100% by 
    Submitting Contributor (Non-Committer) and Submitted under the
    terms of the Project License". But the steps following from that are not 
    completely clear to me.
    First of all, it says the submitter needs to log a Bugzilla entry and 
    attach code. But then later in the flow (page 3) it talks about creating 
    a CQ and _again_ attaching the code as a zip. Do we really need to do 
    both? Or is simply submitting a CQ once and attaching the contribution 
    to the resulting IPZilla issue enough?
    Second question: can I, as project lead, submit the CQ/Bugzilla 
    ticket(s) on behalf of the submitter?
    Final question: should the zip file we submit already be the "ready to 
    go" version, that is use the project license headers and package 
    structure and so on?
    Kind regards,
    incubation mailing list
    To change your delivery options, retrieve your password, or unsubscribe from this list, visit

Back to the top