| Re: [henshin-user] Creating "same" edge as "forbid" and "create" |
Dear all, Am 23.07.16 um 14:33 schrieb Daniel Strüber:
I have committed a fix [1] that addresses this particular edge case: a newly added edge between two <<preserve>> nodes with a <<forbid>> edge between is now set to <<create>> rather than <<preserve>>, which is the only meaningful option in this case. Using this fix, the editor should work in your example as intended. [1] https://git.eclipse.org/r/#/c/77804/ @ Committers: Can someone check and give a +1?
I am not super sure whether fixing one edge case with special code for another edge case is a good idea. Particularly, i am not sure whether the code works always as intended, e.g., if you have complex nested conditions.
I think a better solution would be to remove the special clean up functionality and instead work with validations and provide the special clean up functionalities as quick fixes. Then the user can decide on the correct solution.
What do you think? Cheers, mtt
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature