Re: [glassfish-dev] JSF Templating -- What is blocking?

[Romain Grecourt <romain.grecourt@xxxxxxxxxx>]

    On 5/5/20 11:59 AM, arjan tijms wrote:

Hi,

Woodstock is one of the projects that uses an embedded Jenkinsfile instead of the script that most projects are using.

See: https://github.com/eclipse-ee4j/glassfish-woodstock/blob/master/Jenkinsfile

One could argue whether this is really needed, as the Jenkinsfile assumes intimate knowledge about (specifically) the Kubernetes cluster it's running on.

    The inline YAML template for the k8s pod is definitely not ideal.
    IIRC the only reason for it being there is to implement the shared
    local repository.
    
    This can be fixed by registering templates in the Jenkins master and
    assigning labels to them.
    You can then select which template to use by specifying the label in
    the Jenkinsfile like this:
    
      agent {
        label "my-template-label"
      }
    
    Not sure we have permissions to add templates on the current Jenkins
    setup, but if we wanted to go that way I'm sure we can work things
    out with the eclipse infra team.

In this case one of the issues is the runAsUser, which is randomised on OpenShift (the cloud that Eclipse uses). I can fix the Jenkinsfile, but in addition I think it might be a good idea to add a "regular" job that uses the default Eclipse CI Kubernetes and JNLP images as well.

    Multibranch pipelines are way better than plain old Jenkins jobs. It
    enables the GitHub PR workflow out of the box and thus makes
    contributions easy.
    IMO this is a must have for every single project with code.
    
    Also, the default template will not have a shared local repository
    or have sufficient resource limits.
    You may also run into some tests issues (.e.g IIRC CTS won't pass if
    sendmail isn't running)

Kind regards,

Arjan

On Tue, May 5, 2020 at 8:45 PM <dmitry.kornilov@xxxxxxxxxx> wrote:

I'll ask someone from my team to take a look.

-- Dmitry

> -----Original Message-----
> From: Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>
> Sent: Tuesday, May 5, 2020 7:38 PM
> To: Ed Bratt <ed.bratt@xxxxxxxxxx>; glassfish developer discussions
> <glassfish-dev@xxxxxxxxxxx>; Gaurav Gupta <gaurav.gupta@xxxxxxxxxxx>;
> arjan tijms <arjan.tijms@xxxxxxxxx>; Steve Millidge (Payara)
> <steve.millidge@xxxxxxxxxxx>; Eliot Martin <eliot.martin@xxxxxxxxxxx>;
> DMITRY.KORNILOV <dmitry.kornilov@xxxxxxxxxx>
> Subject: RE: JSF Templating -- What is blocking?
>
> Someone needs to look at the Jenkins release job as it doesn't work and the
> Payara team are not sure who created it.
>
> -----Original Message-----
> From: Ed Bratt <ed.bratt@xxxxxxxxxx>
> Sent: 05 May 2020 18:35
> To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>; Gaurav
> Gupta <gaurav.gupta@xxxxxxxxxxx>; arjan tijms <arjan.tijms@xxxxxxxxx>;
> Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>; Eliot Martin
> <eliot.martin@xxxxxxxxxxx>; DMITRY.KORNILOV
> <dmitry.kornilov@xxxxxxxxxx>
> Subject: JSF Templating -- What is blocking?
>
> Hi,
>
> In Steering committee today, a comment was made regarding issues with
> producing a snapshot for JSF Templating and that this was blocking progress
> with Eclipse GlassFish.
>
> I can see Repo. activity toward producing 3.0.0-SHAPSHOT. I do not see a
> release at the GH repository. Can someone here provide more details?
> What is blocking and how might we help. (OR, perhaps, the issue(s) have
> been cleared and this is no longer holding back progress with the Eclipse
> GlassFish implementation.)
>
> Thanks,
>
> -- Ed

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev