Re: [egit-dev] 5.7 in a product build that is based on eclipse 4.14 (201

[Johan Compagner <jcompagner@xxxxxxxxx>]

how would i do that exactly?

because the feature: org.eclipse.jgit.http.apache

does have hardcoded the dependencies to (jgit 5.7)

<plugin
         id="org.apache.httpcomponents.httpcore"
         download-size="350"
         install-size="693"
         version="4.4.12.v20200108-1212"
         unpack="false"/>

   <plugin
         id="org.apache.httpcomponents.httpclient"
         download-size="1015"
         install-size="2188"
         version="4.5.10.v20200114-1512"
         unpack="false"/>

so that feature will force that

But in eclipse 4.14 (and jgit 5.6) this is forced by i guess some feature:

   <plugin
         id="org.apache.httpcomponents.httpcore"
         download-size="348"
         install-size="689"
         version="4.4.10.v20190123-2214"
         unpack="false"/>

   <plugin
         id="org.apache.httpcomponents.httpclient"
         download-size="1005"
         install-size="2164"
         version="4.5.6.v20190503-0009"
         unpack="false"/>

so our product build will provide both things..

(and then dependencies on that that are then pulled in like apache codec)

So i will get duplicates no matter what.. right?

On Thu, 19 Mar 2020 at 15:59, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:

On Thu, Mar 19, 2020 at 3:46 PM Johan Compagner <jcompagner@xxxxxxxxx> wrote:

yes thats what i now id

i use the 5.6.1 instead of 5.7 p2 update site.

I meant to use EGit 5.7 but select the dependency versions matching the versions in Eclipse 4.14 in your product build

 

Then it works fine.

Also i think if you just do an eclipse 4.14 and install there 5.7 it will work i guess?

But something in our product makes it behave very very weird.

On Thu, 19 Mar 2020 at 15:41, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:

On Thu, Mar 19, 2020 at 3:24 PM Johan Compagner <jcompagner@xxxxxxxxx> wrote:

On Thu, 19 Mar 2020 at 15:13, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:

On Thu, Mar 19, 2020 at 2:10 PM Johan Compagner <jcompagner@xxxxxxxxx> wrote:

Hi,

just want to let you know about a very weird behavior that we had when creating our product.

until now i always just used:  http://download.eclipse.org/egit/updates

to build our product, so egit auto upgraded, that worked fine for quite some time

But suddenly when i think we got 5.7 pushed our product didn't really start normally anymore

Not sure what it is but when i click on our exe file, it takes about 2 minutes (cpu usage is very high) before the choose workspace dialog pops up. If i look at it what it really does it is osgi/felix container threads doing stuff (over 6 or so threads)

the change is (besides of course egit/jgit updates) that i suddenly have a few plugins that are suddenly duplicate:

I guess our product builds on features that uses code 1.10 and that older http stuff and now egit/jgit uses newer version of that..

There are also other changes so its a bit tricky to understand why eclipse launcher is suddenly so busy with..

The EGit 5.7.0.202003110725-r p2 repository contains the versions of the dependencies needed at runtime given in

https://git.eclipse.org/r/plugins/gitiles/egit/egit/+/v5.7.0.202003110725-r/org.eclipse.egit.target/orbit/R20200224183213-2020-03.tpd

EGit comes with the versions given in this target platform definition but should also work with different versions of dependencies,

as long as those versions are compatible and within the version range given in the respective JGit/EGit bundle's manifest.

E.g. 

https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/v5.7.0.202003110725-r/org.eclipse.jgit/META-INF/MANIFEST.MF#160

https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/v5.7.0.202003110725-r/org.eclipse.jgit.http.apache/META-INF/MANIFEST.MF#11

https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/v5.7.0.202003110725-r/org.eclipse.jgit.ssh.apache/META-INF/MANIFEST.MF#35

I guess you probably need to pin the exact version of all dependencies your product assembles when building your product.

that is what we do in our feature.. we fix it

Problem is in Eclipse and all the features that all the features do this. So you kind of depend on the eclipse features we also build on..

But as i said i don't know what happens here exactly

But if i build our product with egt 5.7 then i got those duplicates (and some other changes i think)

i get those duplicates because of other features (eclipse 4.14) that wants to have those explicitly

So even if our feature targets the same http and codec version that egit now brings i still have duplicates (coming from other dependencies)

does it work if your product build uses the versions coming with your eclipse platform version 4.14 ?
EGit 5.7 is shipped with 4.15 and we usually agree on a common version of dependencies across

the release train.

 

But also then our product doesn't really start correctly (it does start but it takes 2 minutes of high cpu usage)

here you see a run of 30 seconds of crunch  time..

That takes 2 minutes at least..

all those "Equinox resolver thread - Equinox Container: 0c1906c2-b81e-42bd-b1ee-e28b0bc7de08 Group: 'main' Native ID: 9296"

are pretty much doing the same thing then..

I don't know why this happens. I am not a p2 expert but only a user