Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] [External] : Re: EclipseLink 2.7.9 (Final) release

On 6/23/21 8:53 PM, William Dazey wrote:
On Wed, Jun 23, 2021 at 2:46 AM Radek Felcman <radek.felcman@xxxxxxxxxx> wrote:
But as understand Your question leads into org.eclipse.persistence.asm*.jar naming .
I see there two options:
1. Keep there naming without qualifier "org.eclipse.persistence.asm.jar" because it is used/consumed as a 3rd party dependency from 2.7.9?
2. Change file name into previous format e.g. "org.eclipse.persistence.asm_9.0.0.v202010211629.jar" ?

I would prefer any bundle to have a qualifier on the end that is
consistent with the other similar bundles. If there is a good reason
for ASM NOT to have a qualifier, then I am going to ask why does ANTRL
get a qualifier? Both are thirdparty dependencies, yes? I prefer we
default to consistency rather than exception, unless there is a good
reason for a change.

In general, if Bundle-Version value in manifest does not match the version value in the file name, p2 (eclipse update site) has troubles publishing artifacts. Basically what p2 expects is a file name following the "'Bundle-Name'_'Bundle-Version'.jar" pattern, where 'Bundle-*' comes from jar's manifest file.




It is a convenience to have a qualifier on the end of the bundle, but
I just want to make sure this difference is seen and investigated. I
vote for adding a qualifier.

About 3.0.2 release:
Did You find some time to check:
Lukas PR;!!GqivPVa7Brio!JWWMysYuSQZpIP-1RBMIga8s9WfujZnop6I0GJp4RHUgLsh-l0ex4NifJ1tJLFDbWUY$
and My PR;!!GqivPVa7Brio!JWWMysYuSQZpIP-1RBMIga8s9WfujZnop6I0GJp4RHUgLsh-l0ex4NifJ1tJU7vogog$
We'd like to know Your opinion about this (which modification You prefer).

I won't lie, I'm not a maven expert and I don't know which changes are
appropriate. Are these competing PRs meant to fix a specific issue I
mentioned? Reading the descriptions for both, I am not sure what the
purpose of the changes are or what I can review to verify the changes
look correct. I would appreciate a layman explanation with a before vs
after comparison if possible. Sorry.

Will Dazey
eclipselink-dev mailing list
To unsubscribe from this list, visit;!!GqivPVa7Brio!JWWMysYuSQZpIP-1RBMIga8s9WfujZnop6I0GJp4RHUgLsh-l0ex4NifJ1tJWBUF7nI$

Back to the top