Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] [External] : Re: EclipseLink 2.7.9 (Final) release 
On Wed, Jun 23, 2021 at 2:46 AM Radek Felcman <radek.felcman@xxxxxxxxxx> wrote:
> But as understand Your question leads into org.eclipse.persistence.asm*.jar naming .
> I see there two options:
> 1. Keep there naming without qualifier "org.eclipse.persistence.asm.jar" because it is used/consumed as a 3rd party dependency from 2.7.9?
> 2. Change file name into previous format e.g. "org.eclipse.persistence.asm_9.0.0.v202010211629.jar" ?

I would prefer any bundle to have a qualifier on the end that is
consistent with the other similar bundles. If there is a good reason
for ASM NOT to have a qualifier, then I am going to ask why does ANTRL
get a qualifier? Both are thirdparty dependencies, yes? I prefer we
default to consistency rather than exception, unless there is a good
reason for a change.

eclipselink-plugins-2.7.9.v20210604-2c549e2208
```
    org.eclipse.persistence.antlr_3.5.2.v201711011707.jar
    org.eclipse.persistence.asm.jar
    org.eclipse.persistence.core_2.7.9.v20210604-2c549e2208.jar
    org.eclipse.persistence.jpa.jpql_2.7.9.v20210604-2c549e2208.jar
```

eclipselink-plugins-2.7.8.v20201217-ecdf3c32c4
```
    org.eclipse.persistence.antlr_3.5.2.v201711011707.jar
    org.eclipse.persistence.asm_9.0.0.v202010211629.jar
    org.eclipse.persistence.core_2.7.8.v20201217-ecdf3c32c4.jar
    org.eclipse.persistence.jpa.jpql_2.7.8.v20201217-ecdf3c32c4.jar
```

It is a convenience to have a qualifier on the end of the bundle, but
I just want to make sure this difference is seen and investigated. I
vote for adding a qualifier.

> About 3.0.2 release:
> Did You find some time to check:
> Lukas PR https://github.com/eclipse-ee4j/eclipselink/pull/1182
> and My PR https://github.com/eclipse-ee4j/eclipselink/pull/1183
> We'd like to know Your opinion about this (which modification You prefer).

I won't lie, I'm not a maven expert and I don't know which changes are
appropriate. Are these competing PRs meant to fix a specific issue I
mentioned? Reading the descriptions for both, I am not sure what the
purpose of the changes are or what I can review to verify the changes
look correct. I would appreciate a layman explanation with a before vs
after comparison if possible. Sorry.


Thanks,
Will Dazey

Back to the top