Hi Gordon, all,
I have now resynched and resteted this on MySQL ->
OK.
In the test
org.eclipse.persistence.testing.tests.wdf.jpa1.lock.TestOptimistic,
I have added test cases that check for a
javax.persistence.OLE in the following cases
upon commit
upon explicit flush
upon implicit flush (by query)
the tests are executed with JDBC batching enabled and
disabled.
To get the tests of these six combinations pass (i.e. fail
with a JPA-OLE), I had to introduce an additional translation from
eclipselink-OLE to JPA-OLE at
RepeatableWriteUnitOfWork.commitRootUnitOfWork
and at
EntityManagerImpl.flush.
This seems to be working. However, it still apears
questionable to me that OLEs are translated in RepeatableWriteUnitOfWork, which is part of the core component. I think
all OLEs should be translated in the jpa component.
Could you please have
another look?
Thanks,
-Adrian
SAP AG
Dietmar-Hopp-Allee 16, 69190 Walldorf,
Germany
Sitz der
Gesellschaft/Registered Office: Walldorf, Germany
Vorstand/SAP Executive Board: Henning
Kagermann (Sprecher/CEO), Léo Apotheker (stellvertretender Sprecher/Deputy CEO),
Werner Brandt, Claus Heinrich, Gerhard Oswald, John Schwarz, Peter
Zencke
Vorsitzender des
Aufsichtsrats/Chairperson of the SAP Supervisory Board: Hasso
Plattner
Registergericht/Commercial Register Mannheim No HRB
350269
The patch for 320413 looks fine to me. I got the bug numbers
mixed up in my previous response
For bug 320643 if commitToDatabase is
translating the OLE then commitTransactionAfterWriteChanges should never catch
an EclipseLink OLE.
I will try to take a look today and at least check
in 320413 if you do not get to it
first.
--Gordon
Goerler, Adrian wrote:
Hi Gordon,
thanks for checking the patches.
I am on vacation for a while starting form pretty much
right now. Please feel free to take these two bugs. Otherwise we have to
leave them hanging until I'm back.
Best regards,
Adrian
SAP AG
Dietmar-Hopp-Allee 16,
69190 Walldorf, Germany
Sitz der
Gesellschaft/Registered Office: Walldorf, Germany
Vorstand/SAP Executive Board:
Henning Kagermann (Sprecher/CEO), Léo Apotheker (stellvertretender
Sprecher/Deputy CEO), Werner Brandt, Claus Heinrich, Gerhard Oswald, John
Schwarz, Peter Zencke
Vorsitzender des
Aufsichtsrats/Chairperson of the SAP Supervisory Board: Hasso
Plattner
Registergericht/Commercial Register Mannheim No HRB
350269
Hello
Adrian,
I apologize for not responding to your earlier enquiry
on the RepeatableWriteUnitOfWork.
The patch for https://bugs.eclipse.org/bugs/show_bug.cgi?id=320643 looks fine but the translation of the
EclipseLink OLE to the JPA OLE needs to happen in 'commitToDatabase' as
this is a common intersection of the em.flush and transaction commit
execution paths. By moving the translation up OLE resulting from
em.flush() will not be translated. I am not sure why you were not
getting the translation with Batch Writing as
'commitToDatabaseWithChangeSet' which your try code is wrapping does call
'commitToDatabase'.
--Gordon
Goerler, Adrian
wrote:
Hi,
I am putting these two patches up for review:
Could someone please have a look?
Tested on MySQL: CORE-LRG (OK besides 3 current issues), JPA-LRG
(OK), WDF (OK)
-Adrian
SAP AG
Dietmar-Hopp-Allee 16, 69190
Walldorf, Germany
Sitz der
Gesellschaft/Registered Office: Walldorf, Germany
Vorstand/SAP Executive Board:
Henning Kagermann (Sprecher/CEO), Léo Apotheker (stellvertretender
Sprecher/Deputy CEO), Werner Brandt, Claus Heinrich, Gerhard Oswald,
John Schwarz, Peter Zencke
Vorsitzender des
Aufsichtsrats/Chairperson of the SAP Supervisory Board: Hasso
Plattner
Registergericht/Commercial
Register Mannheim No HRB 350269
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
