Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipselink-dev] bugs 320413 and 320643 - batching on MySQL - please review
Hello Adrian,
  I apologize for not responding to your earlier enquiry on the RepeatableWriteUnitOfWork. 
  The patch for https://bugs.eclipse.org/bugs/show_bug.cgi?id=320643 looks fine but the translation of the EclipseLink OLE to the JPA OLE needs to happen in 'commitToDatabase' as this is a common intersection of the em.flush and transaction commit execution paths.  By moving the translation up OLE resulting from em.flush() will not be translated.  I am not sure why you were not getting the translation with Batch Writing as 'commitToDatabaseWithChangeSet' which your try code is wrapping does call 'commitToDatabase'.

--Gordon

Goerler, Adrian wrote:
Hi,
 
I am putting these two patches up for review:
 
 
 
Could someone please have a look?
 
Tested on MySQL: CORE-LRG (OK besides 3 current issues), JPA-LRG (OK), WDF (OK)
 
-Adrian
 
SAP AG
Dietmar-Hopp-Allee 16, 69190 Walldorf, Germany
 
Sitz der Gesellschaft/Registered Office: Walldorf, Germany
Vorstand/SAP Executive Board: Henning Kagermann (Sprecher/CEO), Léo Apotheker (stellvertretender Sprecher/Deputy CEO), Werner Brandt, Claus Heinrich, Gerhard Oswald, John Schwarz, Peter Zencke
Vorsitzender des Aufsichtsrats/Chairperson of the SAP Supervisory Board: Hasso Plattner
Registergericht/Commercial Register Mannheim No HRB 350269
 
 
 

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Back to the top