Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[eclipselink-dev] bug 320413 - UPDATE batching on MySQL appears to be broken
Hi,
 
 
I've checked in a fix for this bug at #8217.
 
Reviewed by Gordon, resynced, build and tested on MySQL -> OK.
 
-Adrian
 

Von: Gordon Yorke [mailto:gordon.yorke@xxxxxxxxxx]
Gesendet: Freitag, 23. Juli 2010 15:06
An: Goerler, Adrian
Cc: Dev mailing list for Eclipse Persistence Services
Betreff: Re: AW: [eclipselink-dev] bugs 320413 and 320643 - batching on MySQL - please review

The patch for 320413 looks fine to me.  I got the bug numbers mixed up in my previous response

For bug 320643 if commitToDatabase is translating the OLE then commitTransactionAfterWriteChanges should never catch an EclipseLink OLE.

I will try to take a look today and at least check in 320413 if you do not get to it first.

--Gordon



Goerler, Adrian wrote:
Hi Gordon,
 
 
thanks for checking the patches.
 
You were right. My propsoed translation of EclipseLink OLE to JPA OLE did not work with flush. I have proposed a new patch (attached to https://bugs.eclipse.org/bugs/show_bug.cgi?id=320643). This patch no also includes the regresion tests (also for flush).
 
 
I am on vacation for a while starting form pretty much right now. Please feel free to take these two bugs. Otherwise we have to leave them hanging until I'm back.
 
 
Best regards,
 
Adrian
 
 

SAP AG
Dietmar-Hopp-Allee 16, 69190 Walldorf, Germany

Sitz der Gesellschaft/Registered Office: Walldorf, Germany
Vorstand/SAP Executive Board: Henning Kagermann (Sprecher/CEO), Léo Apotheker (stellvertretender Sprecher/Deputy CEO), Werner Brandt, Claus Heinrich, Gerhard Oswald, John Schwarz, Peter Zencke

Vorsitzender des Aufsichtsrats/Chairperson of the SAP Supervisory Board: Hasso Plattner
Registergericht/Commercial Register Mannheim No HRB 350269

 

Von: eclipselink-dev-bounces@xxxxxxxxxxx [mailto:eclipselink-dev-bounces@xxxxxxxxxxx] Im Auftrag von Gordon Yorke
Gesendet: Donnerstag, 22. Juli 2010 21:42
An: Dev mailing list for Eclipse Persistence Services
Betreff: Re: [eclipselink-dev] bugs 320413 and 320643 - batching on MySQL - please review

Hello Adrian,
  I apologize for not responding to your earlier enquiry on the RepeatableWriteUnitOfWork. 
  The patch for https://bugs.eclipse.org/bugs/show_bug.cgi?id=320643 looks fine but the translation of the EclipseLink OLE to the JPA OLE needs to happen in 'commitToDatabase' as this is a common intersection of the em.flush and transaction commit execution paths.  By moving the translation up OLE resulting from em.flush() will not be translated.  I am not sure why you were not getting the translation with Batch Writing as 'commitToDatabaseWithChangeSet' which your try code is wrapping does call 'commitToDatabase'.

--Gordon

Goerler, Adrian wrote:
Hi,
 
I am putting these two patches up for review:
 
 
 
Could someone please have a look?
 
Tested on MySQL: CORE-LRG (OK besides 3 current issues), JPA-LRG (OK), WDF (OK)
 
-Adrian
 
SAP AG
Dietmar-Hopp-Allee 16, 69190 Walldorf, Germany
 
Sitz der Gesellschaft/Registered Office: Walldorf, Germany
Vorstand/SAP Executive Board: Henning Kagermann (Sprecher/CEO), Léo Apotheker (stellvertretender Sprecher/Deputy CEO), Werner Brandt, Claus Heinrich, Gerhard Oswald, John Schwarz, Peter Zencke
Vorsitzender des Aufsichtsrats/Chairperson of the SAP Supervisory Board: Hasso Plattner
Registergericht/Commercial Register Mannheim No HRB 350269
 
 

_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev

Back to the top