Re: [eclipselink-dev] Patch available for review... 297217

[Eric Gwin <eric.gwin@xxxxxxxxxx>]

Micheal,

Thanks for volunteering as much time as you could. Upon review, I've 
noticed some issues I'm going to need to fix, so this won't be the patch 
committed.

I would however, appreciate a "conceptual" review - as far as the 
variable renames, and WRT the merging of buildfile styles between Moxy 
and Core. I expect to do similar things in the other components test 
builds as far as the classpath, and macro usage, etc.

-Eric

Michael O'Brien wrote:
> Eric,
>    This patch is significant - as as Tom states should be formally 
> reviewed in priority sequence.
>    I have quickly looked at 1/3 of the patch so far - the renaming, 
> the cdata fixes, the new build targets (I have no access to verify the 
> build server scripts).
>    A full review should patch in the changes to a view and run the 
> targets as well - I just have not had any time to do a full review.
>    Regardless, early adopters of the change will pick up most runtime 
> issues with the changes as soon as we do a refresh.
>    thank you
>    /michael
>   Eric Gwin wrote:
> > I haven't received any response from the previous email, and could 
> > come to two possible conclusions:
> > - No one is interested enough in the fix to review it. or
> > - It wasn't noticed because the announcement was hidden in another 
> > thread.
> >
> > If there is no interest, I will commit this patch after the M1 
> > milestone for 2.1.0 is complete.
> >
> > This patch implements several proposed changes:
> > - To the test build standards as outlined below.
> > - To the build standards as discussed in a separate thread (.jar, 
> > .lib, .dir, and other defined standards)
> > - It starts the process of cleaning up classpaths by defining each 
> > dependency (rather than using
> >  a single variable: eclipselink.core.depend).
> > - It demonstrates a merging of test build styles between core and moxy.
> >
> >
> > Eric
> >
> >
> > Eric Gwin wrote:
> > > I've created  a bug and added a patch for review:
> > >
> > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=297217
> > >
> > > The patch includes:
> > > - prototype of MOXy test with new standards applied
> > > - inclusion of new build standards (property names - for use with 
> > > future dependency work)
> > > - ability to create product jars without compiling
> > >   - rework to oracle, to intelligently determine if only repackage, 
> > > or full package/repackage is needed at execution time.
> > >
> > > If interested, please review.
> > >
> > > -Eric
> > >
> > > Eric Gwin wrote:
> > > > I did forget to mention we did talk about minimal classpaths. I 
> > > > don't recall if it was determined (or assumed) if we should make an 
> > > > effort at this time to re-factor to use minimal jar dependencies.
> > > >
> > > > -Eric
> > > >
> > > > Eric Gwin wrote:
> > > > > All,
> > > > >
> > > > > Yesterday a meeting was held between all parties who expressed 
> > > > > interest in the test rework plan. Below is a summary of the 
> > > > > revised plan:
> > > > >
> > > > > - Test builds will all have config specific compile and run targets
> > > > >   - for example: compile-against-jar, compile-against-bundles, 
> > > > > compile-against-classes and run-against-jar, run-against....
> > > > >   - JPA will need to have the eclipselink.jar in the CP, even for 
> > > > > compile-against-classes (unless including the resources works
> > > > >     for the processing of _classes).
> > > > > - run will not depend upon compile
> > > > >   - MOXy and SDO will have the run dependency upon compile broken
> > > > >   - default component targets will still
> > > > > - default execution paths will use ...against-jar
> > > > > - There needs to be a documented means of testing against a 
> > > > > specific build (jar or bundle)
> > > > >  - Maven was chosen as the desired mechanism for retrieving 
> > > > > specific builds for testing
> > > > >  - It was determined that the Maven-test scripts were beyond scope 
> > > > > of this particular effort
> > > > >  - QA was going to investigate getting this process going
> > > > >  - It was also determined that with Maven in place there would be 
> > > > > little need to have eclipselink.jar commited post-build to SVN
> > > > >    (But that is also beyond scope)
> > > > > - a desire was expressed for a way to assemble the bundles and 
> > > > > jars without forcing a compile
> > > > >  - developers would like a way to use Eclipse generated classes to 
> > > > > run against-jar tests.
> > > > >  - I will investigate. It should be a simple matter of an 
> > > > > additional high level target (Again it is slightly out of scope).
> > > > >
> > > > > Did I miss anything?
> > > > >
> > > > > -Eric
> > > > >
> > > > >
> > > > >
> > > > > _______________________________________________
> > > > > eclipselink-dev mailing list
> > > > > eclipselink-dev@xxxxxxxxxxx
> > > > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > > > _______________________________________________
> > > > eclipselink-dev mailing list
> > > > eclipselink-dev@xxxxxxxxxxx
> > > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > > _______________________________________________
> > > eclipselink-dev mailing list
> > > eclipselink-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
> > _______________________________________________
> > eclipselink-dev mailing list
> > eclipselink-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
>
> _______________________________________________
> eclipselink-dev mailing list
> eclipselink-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/eclipselink-dev