Here is analysis for why testClosedEmShouldThrowException() fails -
---------------
It fails because the test code calls em.lock(null, null) and the fix
for 263297 is as follows
public void lock(Object entity, LockModeType lockMode, Map properties)
{
try
{
if(*lockMode.name().contains*(ObjectLevelReadQuery.NONE)){ //we
get a NPE since lockMode is null
return;
}
....
----------------
fieldaccess.testMergeDetachedObject() fails because it tries to insert
a detached department again to the database. The test also fails on a
clean workspace with the fix for 263297 rolled back.
I have attached a new fix to the issue 263297 which corrects this and
couple of other issues with the method. Please review the fix and
comment.
Thanks,
Mitesh
Mitesh Meswani wrote:
I have
rolled back the offending changes till we investigate root cause of the
test failures and correct fix for the issue. Darani had run the tests
in her environment to check for regression before the checkin some how
the errors were not observed then. Obviously something must have been
wrong with the environment.
Regards,
Mitesh
Edwin Tang wrote:
Hi Guy,
fieldaccess.testMergeDetachedObject should be caused by the fix for
263297 as well.
Thanks,
Edwin
-----Original Message-----
From: Christopher Delahunt Sent: February 13, 2009 12:52 PM
To: Guy Pelletier; Dev mailing list for Eclipse Persistence Services
Subject: Re: [eclipselink-dev] Test failures and errors
testClosedEmShouldThrowException fails with the fix for 263297
I'm not sure why the other fails.
Regards,
Chris
Guy Pelletier wrote:
All,
I'm seeing 2 test failures when running FullRegression, namely:
-
advanced.EntityManagerJUnitTestSuite.testClosedEmShouldThrowException.
- same test (so same problem) in fieldaccess as well.
And one 1 test error:
- fieldaccess.testMergeDetachedObject
Any ideas before I dig into them further?
Cheers,
Guy
------------------------------------------------------------------------
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
_______________________________________________
eclipselink-dev mailing list
eclipselink-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/eclipselink-dev
|
