Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[eclipselink-dev] RE: RE: Using JUnit4 and Ant in EclipseLink ...

2) The PB4 code has been in ADE for many months now and was extensively
tested and reviewed by QA. Following this logic, then we need to review
the internal testing framework?

3) The package names follow the standard for extensions to JUnit4.

4) There is javadoc on the public component
but yes, I do need to add more ..

6) trying to stop the screaming from Doug ...

Gordon Yorke wrote:
> [MWN - added numbers]
> 1) IPzilla approvals are legal approvals and are not community/technically
> based.
> 2) There has been no review of this code by any other committer.
> 3) The package names do not follow Eclipse guidelines.
> 4) The code includes almost no javadoc or developer comments.
> 5) There has been no testing infrastructure formalization making this code
> premature.
> 6) Bug I guess bringing this up is pointless as the repository changes
> have already been made without any pause for feedback.
> --Gordon
> -----Original Message-----
> From: eclipselink-dev-bounces@xxxxxxxxxxx
> [mailto:eclipselink-dev-bounces@xxxxxxxxxxx]On Behalf Of Michael Norman
> Sent: Tuesday, October 02, 2007 1:43 PM
> To: eclipselink-dev@xxxxxxxxxxx
> Subject: [eclipselink-dev] RE: Using JUnit4 and Ant in EclipseLink ...
> A quick perusal of some other Eclipse projects show that their top-level
> folders rarely have
> anything to do with bugzilla components. Now this is either because those
> project-owners
> didn't set out to make it work out that way, or inevitably the mis-match
> between CVS/SVN directory
> structures, Eclipse projects and bugzilla leads you away from this idea
> ...
> time will tell.
> I still think now would be the best time to introduce a 'commons' folder,
> but obviously I'm
> on the losing end of this vote.
> so ... moving stuff into core:
>    - check-in ant.jar into eclipselink.core.lib (OK according to CQ 1768)
>    - check-in the source to the pb4 JUnit4 runner into
> eclipselink.core.test
> (OK according to CQ 1755)
> +1 from me ;-)

View this message in context:
Sent from the EclipseLink - Dev mailing list archive at

Back to the top