Re: [eclipse.org-architecture-council] 1000 line CQ limit - (revisited?)

[Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx>]

For this example, I'd likely argue that the preferences are not intellectual property contributions. I would include the test code, however.

Wayne

On Thu, May 28, 2020 at 4:32 PM Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

> Chopping up commits to fit inside the limit violates the spirit of the requirement. Don't do that.

Yes I agree - and I have stepped in in the (recent) past to make sure this didn't happen.

Some specific examples of where actual effort was expended to reduce contribution size:

- https://git.eclipse.org/r/c/149953/7 was reduced (in part) due to 1000 LOC limit - see conversation around patch set 7-9. 

- https://git.eclipse.org/r/c/81158/21 - see conversation around patch set 21

The first example is a perfect example IMHO - it was a single line of code change, with a new test that is about 12 lines of code. But because this contributor wrote tests for a bundle that was never tested before a lot of non-code needed to be added. So the other nearly 1000 lines are a combination of .prefs files (over 500 lines) and other changes with no IP. In the end the final contribution was +921 -1

Jonah

 

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

On Thu, 28 May 2020 at 15:43, Wayne Beaton <wayne.beaton@xxxxxxxxxxxxxxxxxxxxxx> wrote:

Chopping up commits to fit inside the limit violates the spirit of the requirement. Don't do that.

Wayne

On Thu, May 28, 2020 at 3:36 PM Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:

Hi folks,

I would like to discuss the 1000 line CQ limit and what it means in practice. I often see well intentioned committers asking contributors to reduce the size of their commits, or sometimes to split them up, so that each individual contribution is less than the magic number. In the distant past this number was much less than 1000.

This seems to be more of an issue in the gerrit world because there is a genie reminding users that a CQ is needed. In github hosted projects I can see little evidence of any code going through this process at all. 

Can we revisit removing this requirement? Or better defining the 1000 line limit so that contributors aren't asked to adjust their coding simply based on this limit.

Thanks,

Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

_______________________________________________
eclipse.org-architecture-council mailing list
eclipse.org-architecture-council@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse.org-architecture-council

--

Wayne Beaton

Director of Open Source Projects | Eclipse Foundation, Inc.

Join us at our virtual event: EclipseCon 2020 - October 20-22

_______________________________________________
eclipse.org-architecture-council mailing list
eclipse.org-architecture-council@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse.org-architecture-council

_______________________________________________
eclipse.org-architecture-council mailing list
eclipse.org-architecture-council@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse.org-architecture-council

--

Wayne Beaton

Director of Open Source Projects | Eclipse Foundation, Inc.

Join us at our virtual event: EclipseCon 2020 - October 20-22