Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[] 1000 line CQ limit - (revisited?)

Hi folks,

I would like to discuss the 1000 line CQ limit and what it means in practice. I often see well intentioned committers asking contributors to reduce the size of their commits, or sometimes to split them up, so that each individual contribution is less than the magic number. In the distant past this number was much less than 1000.

This seems to be more of an issue in the gerrit world because there is a genie reminding users that a CQ is needed. In github hosted projects I can see little evidence of any code going through this process at all. 

Can we revisit removing this requirement? Or better defining the 1000 line limit so that contributors aren't asked to adjust their coding simply based on this limit.


Jonah Graham
Kichwa Coders

Back to the top