Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [] 1000 line CQ limit - (revisited?)

The limit comes from the IP Advisory Committee (I think that the board of directors has some say in this).

So, to change this requirement, we would have to make an appeal to the IP Advisory Committee. i.e., describe why it's unnecessary.

In the meantime, please do not let contributors chop up their commits into arbitrary chunks to fit the limit. The requirement exists for a reason.

FWIW, committers have some discretion with regard to what 1KLOC means. What we're really looking for is contributions of significant new intellectual property. These significant contributions need to be reviewed (and tracked) by the IP team for licensing, provenance, and general shenanigans. I tend to think of it as 1KLOC of meaningful content and "really close" counts (e.g., a contribution of 1,100 lines that includes file headers and blank lines).


On Thu, May 28, 2020 at 3:36 PM Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
Hi folks,

I would like to discuss the 1000 line CQ limit and what it means in practice. I often see well intentioned committers asking contributors to reduce the size of their commits, or sometimes to split them up, so that each individual contribution is less than the magic number. In the distant past this number was much less than 1000.

This seems to be more of an issue in the gerrit world because there is a genie reminding users that a CQ is needed. In github hosted projects I can see little evidence of any code going through this process at all. 

Can we revisit removing this requirement? Or better defining the 1000 line limit so that contributors aren't asked to adjust their coding simply based on this limit.


Jonah Graham
Kichwa Coders
_______________________________________________ mailing list
To unsubscribe from this list, visit


Wayne Beaton

Director of Open Source Projects | Eclipse Foundation, Inc.

Join us at our virtual event: EclipseCon 2020 - October 20-22

Back to the top