Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse.org-architecture-council] about_files and JPMS
I vote to remove the folder altogether. In the current day and age I don’t think these make any difference. But that’s my thought.

On Tue, Aug 27, 2019 at 2:45 PM Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx> wrote:
Greetings AC Members,

Please find an interesting issue below. It looks like out beloved "about_files" folder in jar files is causing issues in Java modules.

As a workaround, there is a recommendation to rename it from "about_files" to "about-files". For a final solution, I wonder if we can get rid of this requirement for jar files altogether. Most other projects I work with include a license file in their final product/distribution but not in every single jar file.

Thoughts?

-Gunnar

-- 
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx, http://guw.io/


Begin forwarded message:

Subject: [Bug 550376] [JUnit 5] Cannot run Jupiter tests in a project with module-info.java after upgrade to JUnit 5.5.1
Date: August 27, 2019 at 21:14:54 GMT+2

https://bugs.eclipse.org/bugs/show_bug.cgi?id=550376
Product/Component: JDT / UI

--- Comment #24 from Stephan Herrmann <stephan.herrmann@xxxxxxxxx> ---
We have something like a recommendation from Alan Bateman in [1]

Forging the list of packages to exclude a given folder doesn't seem to be
supported without hacking the jar tool, but:

"The top-level directory or a location such as META-INF/legal will work of
course."

So, we have some kind of blessing also for "about-files". It solves the
problem, because this folder is not seen as a package, hence JPMS has nothing
to check and hence the boot layer has no reason to blow up.

Conversely, by saying "about_files/EPL.html" we create an "encapsulated"
package "about_files", where "encapsulated" doesn't live up to its promise in a
single-classloader runtime, which will and does blow up.


[1] https://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-August/014284.html

--
You are receiving this mail because:
You are on the CC list for the bug.

_______________________________________________
eclipse.org-architecture-council mailing list
eclipse.org-architecture-council@xxxxxxxxxxx
https://www.eclipse.org/mailman/listinfo/eclipse.org-architecture-council

IMPORTANT: Membership in this list is generated by processes internal to the Eclipse Foundation.  To be permanently removed from this list, you must contact emo@xxxxxxxxxxx to request removal.

Back to the top