Re: [eclipse-pmc] Windows SWT patch reviews

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

Thanks, Niraj for the clarification.

I think code cleanup belongs in the area of code maintenance as it
makes it easier to fix and avoid bugs in the future and hence is also
very important to our project.

Best regards, Lars

On Wed, Apr 10, 2019 at 1:51 PM Niraj Modi <niraj.modi@xxxxxxxxxx> wrote:
>
> Hi Lars,
> You are quoting me wrong, by saying that developers can gain comittership, only if they do feature development work.
> I specifically said “bug fixes” which is code maintenance (fixing of failing use-cases) and not feature work.
>
> Regards,
> Niraj Modi
>
>
> From:        Lars Vogel <lars.vogel@xxxxxxxxxxx>
> To:        eclipse-pmc@xxxxxxxxxxx
> Date:        04/10/2019 02:45 PM
> Subject:        Re: [eclipse-pmc] Windows SWT patch reviews
> Sent by:        eclipse-pmc-bounces@xxxxxxxxxxx
> ________________________________
>
>
>
> Hi Niraj,
>
> > Also, one important point for committership cleanup patches are not enough, we need bug fixes and I'm happy to review them.
>
> I'm not aware of the requirement that developers can only gain
> committership, if they do feature development.
> If we have this requirement, we should IMHO drop it.
>
> If I think of cleanup work, I think of code maintenance.
>
> Maintenance of the existing code basis is IMHO at least of similar
> importance as feature development. Removing code which is outdated and
> updating it, is IMHO key to the future success of IDE. It is also my
> primary focus since several years. For example the EPL 2.0 updates,  I
> did last year. I would love to see other to do more in this area. Code
> maintenance is bug fixing to me.
>
> I usually tell people that the biggest achievement of the 4.8 release
> of the removal of thousands of redundant code lines in the SWT Win
> port. The removal of thousands code lines with almost no side effects
> demonstrates IMHO a deep understanding of the underlying
> implementation.
>
> IMHO we need both in our team: developers interested in doing feature
> work and developers doing maintenance. In the past we gave access to
> new committers also for primary maintenance work.
>
> PMC members, please let me know if you think new committers must do
> feature development, to gain committership. If some of you do, I
> suggest we discuss it in our next meeting on vote on it. I think our
> requirement is that new committers demonstrate an solid understanding
> of the code base and show a certain positive attitude.
>
> Best regards, Lars
>
> On Tue, Apr 9, 2019 at 10:25 AM Niraj Modi <niraj.modi@xxxxxxxxxx> wrote:
> >
> > Hi Alex,
> > The gerrit query that you have shared doesn't give the correct picture, as there are patches in the list that already have responses.
> >
> > Apart from https://git.eclipse.org/r/#/c/139609/whichcame to my notice last week all other patches are basically cleanup which IMHO doesn't become top priority immediately.
> > Lot of time goes into review of big cleanup patches and due to possible side effects it can cause and thorough testing needed, also we need to put time fixing regression as Lars made a mention of one such case in his note: https://www.eclipse.org/lists/eclipse-pmc/msg03649.html
> >
> >  You may remember, we had already invested time and effort to have Conrad to be a Platform committer in the past. But, he is no longer active.
> >  I welcome other platform committers to pitch-in for review of these patches.
> > Also, one important point for committership cleanup patches are not enough, we need bug fixes and I'm happy to review them.
> >
> >  Also, I wonder why this mail was not sent to platform-dev list(and sent only to pmc list)
> >
> > Regards,
> > Niraj Modi
> > ----- Original message -----
> > From: Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
> > Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
> > To: eclipse-pmc@xxxxxxxxxxx
> > Cc:
> > Subject: [eclipse-pmc] Windows SWT patch reviews
> > Date: Mon, Apr 8, 2019 6:53 PM
> >
> > SWT on win32 patches seem to be piling up now (e.g. https://git.eclipse.org/r/#/q/project:platform/eclipse.platform.swt+win32+status:open) and we don't have anyone but Niraj to look at them right now. Considering that and upcoming introduction of svg and other file formats for Linux only right now.
> > It seems correct to me to send a generic plea for help (cross-distro mailing list? initially) for people interested to help out with  the supposedly most used operating system.
> > Also aiming at making the people submitting win32 specific patches committers seems like what should we do in the very short term but the issue for this is that I don't even have access to such maching and I had to borrow one from a friend last week for quick check for project of mine.
> > So what do you think? Can we get Niraj to engage with Nikita (most patches coming from him in the current queue) so we can get him commit rights and unbreak the vicious cycle?
> >
> > --
> > Alexander Kurtakov
> > Red Hat Eclipse Team
> > _______________________________________________
> > eclipse-pmc mailing list
> > eclipse-pmc@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> > https://www.eclipse.org/mailman/listinfo/eclipse-pmc
> >
> > _______________________________________________
> > eclipse-pmc mailing list
> > eclipse-pmc@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> > https://www.eclipse.org/mailman/listinfo/eclipse-pmc
>
>
>
> --
> Eclipse Platform project co-lead
> CEO vogella GmbH
>
> Haindaalwisch 17a, 22395 Hamburg
> Amtsgericht Hamburg: HRB 127058
> Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
> USt-IdNr.: DE284122352
> Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/eclipse-pmc
>
>
>
> _______________________________________________
> eclipse-pmc mailing list
> eclipse-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/eclipse-pmc



-- 
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com