Hi Alex,
The gerrit query that
you have shared doesn't give the correct picture, as there are patches
in the list that already have responses.
Apart from https://git.eclipse.org/r/#/c/139609/which came to my notice last week all other patches are basically cleanup
which IMHO doesn't become top priority immediately.
Lot of time goes into
review of big cleanup patches and due to possible side effects it can cause
and thorough testing needed, also we need to put time fixing regression
as Lars made a mention of one such case in his note: https://www.eclipse.org/lists/eclipse-pmc/msg03649.html
Cleanup patches are important in order to get new contributors - if you look at the GTK port for an example lately we have contributions from a number of new people but this started to happen only after we updated the codebase to a recent enough GTK API so I do believe that such patches are of higher value and priority for the longevity of the project than a fix for a rare bug. At least I can say for sure that it worked the way I say it in the GTK port.
You may remember,
we had already invested time and effort to have Conrad to be a Platform
committer in the past. But, he is no longer active.
Sure, that's what life is :). Companies hire people, invest in them and at the end they can leave too. With sufficient tries you get people that stay.
I welcome other
platform committers to pitch-in for review of these patches.
Also, one important
point for committership cleanup patches are not enough, we need bug fixes
and I'm happy to review them.
Also, I wonder
why this mail was not sent to platform-dev list(and sent only to pmc list)
IMHO, Windows is quite important platform and we are severly lacking resources on it and two weeks ago on the PMC call we discussed about adding SVG/XPM/... images support on linux only initially (M2 contribution should have them) and this will require some effort to be done on other platforms too (Windows matter more than Mac IMHO). As I see you fully booked with Windows work and the patch queue grows we can not expect you to do more and this is when we (PMC) should step in and do smth to help.
Regards,
Niraj Modi
----- Original message
-----
From: Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
Sent by: eclipse-pmc-bounces@xxxxxxxxxxx
To: eclipse-pmc@xxxxxxxxxxx
Cc:
Subject: [eclipse-pmc] Windows SWT patch reviews
Date: Mon, Apr 8, 2019 6:53 PM
SWT on win32 patches
seem to be piling up now (e.g. https://git.eclipse.org/r/#/q/project:platform/eclipse.platform.swt+win32+status:open)
and we don't have anyone but Niraj to look at them right now. Considering
that and upcoming introduction of svg and other file formats for Linux
only right now.
It seems correct to
me to send a generic plea for help (cross-distro mailing list? initially)
for people interested to help out with the supposedly most used operating
system.
Also aiming at making
the people submitting win32 specific patches committers seems like what
should we do in the very short term but the issue for this is that I don't
even have access to such maching and I had to borrow one from a friend
last week for quick check for project of mine.
So what do you think?
Can we get Niraj to engage with Nikita (most patches coming from him in
the current queue) so we can get him commit rights and unbreak the vicious
cycle?
--
Alexander Kurtakov
Red Hat Eclipse Team
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
_______________________________________________
eclipse-pmc mailing list
eclipse-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/eclipse-pmc
