Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-dev] Reminder: Bugs must have review+ on it

I've updated the RC1 Fix approval section of the
http://www.eclipse.org/eclipse/development/plans/freeze_plan_3.6.php with
the new query that checks for review+  or whether there's a
'Documentation', 'example' or 'test' keyword. Please make sure none of your
bugs appear in the list and let me know if there's still false positives.

Dani

|------------>
| From:      |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |Francis Upton <francisu@xxxxxxxx>                                                                                                                 |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To:        |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |"General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>                                                              |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date:      |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |04.05.2010 16:33                                                                                                                                  |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject:   |
|------------>
  >--------------------------------------------------------------------------------------------------------------------------------------------------|
  |Re: [eclipse-dev] Reminder: Bugs must have review+ on it                                                                                          |
  >--------------------------------------------------------------------------------------------------------------------------------------------------|





I assume that changes that only hit tests are in this same category? If so,
how should they be marked?

On Tue, May 4, 2010 at 7:31 AM, Thomas Watson <tjwatson@xxxxxxxxxx> wrote:
  For examples, perhaps we should use the "example" keyword. I would
  suggest the "Documentation" keyword for doc fixes but the description at
  https://bugs.eclipse.org/bugs/describekeywords.cgi seems to be a bit
  different than what we are talking about here ... "For use in bugs
  requiring documentation support."

  Also, why is the p2 bug
  https://bugs.eclipse.org/bugs/show_bug.cgi?id=270668 showing up in the
  search? It has a +1 flag

  Tom



  Susan Franklin McCourt---05/04/2010 09:13:43 AM---Dani, what do you
  suggest for bugs that fix doc or examples and thus don't need review?
  Would you like the committer to +1 them



                                                                       
                                                                       
 From:  Susan Franklin McCourt/Beaverton/IBM@IBMUS                     
                                                                       
                                                                       
 To:    "General development mailing list of the Eclipse project." <   
        eclipse-dev@xxxxxxxxxxx>                                       
                                                                       
                                                                       
 Cc:    eclipse-dev@xxxxxxxxxxx, eclipse-dev-bounces@xxxxxxxxxxx       
                                                                       
                                                                       
 Date:  05/04/2010 09:13 AM                                            
                                                                       
                                                                       
 Subjec Re: [eclipse-dev] Reminder: Bugs must have review+ on it       
 t:                                                                    
                                                                       






  Dani, what do you suggest for bugs that fix doc or examples and thus
  don't need review? Would you like the committer to +1 them so they aren't
  flagged by your query?

  susan

  Daniel Megert ---05/04/2010 04:29:50 AM---Please make sure that a patch
  must be attached if code is involved and a
                                                                       
                                                                       
                                                  D                    
                                                  a To:                
                                                  n eclipse-dev@xxxxxxxxxx
                                                  i g                  
                                                  e cc:                
                                                  l Subject: [eclipse-dev]
                                                  M Reminder: Bugs must
                                                  e have review+ on it 
                                                  g                    
                                                  e                    
                                                  r                    
                                                  t                    
                                                  <                    
                                                  d                    
                                                  a                    
                                                  n                    
                                                  i                    
                                                  e                    
                                                  l                    
                                                  _                    
                                                  m                    
                                                  e                    
                                                  g                    
                                                  e                    
                                                  r                    
                                                  t                    
                                                  @                    
                                                  c                    
                                                  h                    
                                                  .                    
                                                  i                    
                                                  b                    
                                                  m                    
                                                  .                    
                                                  c                    
                                                  o                    
                                                  m                    
                                                  >                    
                                                  S                    
                                                  e                    
                                                  n                    
                                                  t                    
                                                  b                    
                                                  y                    
                                                  :                    
                                                  e                    
                                                  c                    
                                                  l                    
                                                  i                    
                                                  p                    
                                                  s                    
                                                  e                    
                                                  -                    
                                                  d                    
                                                  e                    
                                                  v                    
                                                  -                    
                                                  b                    
                                                  o                    
                                                  u                    
                                                  n                    
                                                  c                    
                                                  e                    
                                                  s                    
                                                  @                    
                                                  e                    
                                                  c                    
                                                  l                    
                                                  i                    
                                                  p                    
                                                  s                    
                                                  e                    
                                                  .                    
                                                  o                    
                                                  r                    
                                                  g                    
                                                                       
                                                                       
                                                  0                    
                                                  5                    
                                                  /                    
                                                  0                    
                                                  4                    
                                                  /                    
                                                  2                    
                                                  0                    
                                                  1                    
                                                  0                    
                                                  0                    
                                                  4                    
                                                  :                    
                                                  2                    
                                                  8                    
                                                  A                    
                                                  M                    
                                                  P                    
                                                  l                    
                                                  e                    
                                                  a                    
                                                  s                    
                                                  e                    
                                                  r                    
                                                  e                    
                                                  s                    
                                                  p                    
                                                  o                    
                                                  n                    
                                                  d                    
                                                  t                    
                                                  o                    
                                                  "                    
                                                  G                    
                                                  e                    
                                                  n                    
                                                  e                    
                                                  r                    
                                                  a                    
                                                  l                    
                                                  d                    
                                                  e                    
                                                  v                    
                                                  e                    
                                                  l                    
                                                  o                    
                                                  p                    
                                                  m                    
                                                  e                    
                                                  n                    
                                                  t                    
                                                  m                    
                                                  a                    
                                                  i                    
                                                  l                    
                                                  i                    
                                                  n                    
                                                  g                    
                                                  l                    
                                                  i                    
                                                  s                    
                                                  t                    
                                                  o                    
                                                  f                    
                                                  t                    
                                                  h                    
                                                  e                    
                                                  E                    
                                                  c                    
                                                  l                    
                                                  i                    
                                                  p                    
                                                  s                    
                                                  e                    
                                                  p                    
                                                  r                    
                                                  o                    
                                                  j                    
                                                  e                    
                                                  c                    
                                                  t                    
                                                  .                    
                                                  "                    
                                                                       
                                                                       




  Please make sure that a patch must be attached if code is involved and a
  review+ must be either on the patch or the bug report. The reviewer can
  be
  the same as the one who gives the +1.

  The following query http://tinyurl.com/RC1-Without-Approval already shows
  many missing review+.

  Dani

  _______________________________________________
  eclipse-dev mailing list
  eclipse-dev@xxxxxxxxxxx
  To change your delivery options, retrieve your password, or unsubscribe
  from this list, visit
  https://dev.eclipse.org/mailman/listinfo/eclipse-dev[attachment
  "pic08750.gif" deleted by Thomas Watson/Austin/IBM]
  _______________________________________________

  eclipse-dev mailing list
  eclipse-dev@xxxxxxxxxxx
  To change your delivery options, retrieve your password, or unsubscribe
  from this list, visit
  https://dev.eclipse.org/mailman/listinfo/eclipse-dev



  _______________________________________________
  eclipse-dev mailing list
  eclipse-dev@xxxxxxxxxxx
  To change your delivery options, retrieve your password, or unsubscribe
  from this list, visit
  https://dev.eclipse.org/mailman/listinfo/eclipse-dev

_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev





Back to the top