Re: [eclipse-dev] Reminder: Bugs must have review+ on it

[Francis Upton <francisu@xxxxxxxx>]

I assume that changes that only hit tests are in this same category? If so, how should they be marked?

On Tue, May 4, 2010 at 7:31 AM, Thomas Watson <tjwatson@xxxxxxxxxx> wrote:

For examples, perhaps we should use the "example" keyword. I would suggest the "Documentation" keyword for doc fixes but the description at https://bugs.eclipse.org/bugs/describekeywords.cgi seems to be a bit different than what we are talking about here ... "For use in bugs requiring documentation support."

Also, why is the p2 bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=270668 showing up in the search? It has a +1 flag

Tom



Susan Franklin McCourt---05/04/2010 09:13:43 AM---Dani, what do you suggest for bugs that fix doc or examples and thus don't need review? Would you like the committer to +1 them

From:	Susan Franklin McCourt/Beaverton/IBM@IBMUS
To:	"General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>
Cc:	eclipse-dev@xxxxxxxxxxx, eclipse-dev-bounces@xxxxxxxxxxx
Date:	05/04/2010 09:13 AM
Subject:	Re: [eclipse-dev] Reminder: Bugs must have review+ on it

---

Dani, what do you suggest for bugs that fix doc or examples and thus don't need review? Would you like the committer to +1 them so they aren't flagged by your query?

susan

Daniel Megert ---05/04/2010 04:29:50 AM---Please make sure that a patch must be attached if code is involved and a

Daniel Megert <daniel_megert@xxxxxxxxxx> Sent by: eclipse-dev-bounces@xxxxxxxxxxx 05/04/2010 04:28 AM Please respond to "General development mailing list of the Eclipse project."

To: eclipse-dev@xxxxxxxxxxx cc: Subject: [eclipse-dev] Reminder: Bugs must have review+ on it

Please make sure that a patch must be attached if code is involved and a
review+ must be either on the patch or the bug report. The reviewer can be
the same as the one who gives the +1.

The following query http://tinyurl.com/RC1-Without-Approval already shows
many missing review+.

Dani

_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/eclipse-dev[attachment "pic08750.gif" deleted by Thomas Watson/Austin/IBM] _______________________________________________

eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

https://dev.eclipse.org/mailman/listinfo/eclipse-dev

_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev