Re: [ecd-pmc] PMC Approval required for Committer Election for Igor Vino

[Martin Lippert <mlippert@xxxxxxxxx>]

Hey Sven,

> We have clarified the case. It was indeed a 'heat of the moment comment after a large PR'.
> Also we discussed how we can improve communication and quality of such PRs.
> So please go ahead and approve the election.

Done. Thanks for the clarification.

Cheers,
-Martin




> 
> Thank you!
> 
> On Tue, 11 Jun 2019 at 14:38, Sven Efftinge <sven.efftinge@xxxxxxxxxx> wrote:
> We have our weekly meeting today at 4pm CEST where we can clarify this.
> 
> On Tue, 11 Jun 2019 at 13:29, Gorkem Ercan <gorkem.ercan@xxxxxxxxx> wrote:
> 
> Hi Sven,
> Can you confirm with Anton that, this was not a heat of the moment 
> comment
> after a large PR ? If you think this should be reconsidered on the 
> project
> I am OK to send it back.
> 
> OTOH, does the way this was raised indicate a lack of communication on 
> the
> Theia project?
> 
> Thanks,
> Gorkem
> 
> On 11 Jun 2019, at 2:46, Sven Efftinge wrote:
> 
> > Hi Martin,
> >
> > yes, the comment sounds like -1 to me. I haven't talked with Anton 
> > yet, but
> > I know he was spending the last two weeks with the respective 
> > contribution
> > and has been very unhappy with it. Not sure this is the best way to 
> > raise
> > such concerns, but at least he doesn't seem to feel comfortable with
> > granting commit rights, yet.
> >
> > Cheers,
> > Sven
> >
> >
> > On Mon, 10 Jun 2019 at 18:02, Martin Lippert <mlippert@xxxxxxxxx> 
> > wrote:
> >
> >> Hey!
> >>
> >> We have a committer election with one “0” vote here, including a
> >> comprehensive explanation for that vote.
> >> How should we deal with this? Maybe this doesn’t us (formally) from
> >> accepting him as committer, but we should not just ignore the “0” 
> >> comment
> >> and the explanation.
> >>
> >> I tend to send this back to the project leads to further discussion.
> >> Opinions?
> >>
> >> Cheers,
> >> -Martin
> >>
> >>
> >>
> >>
> >>
> >> *Von: *emo@xxxxxxxxxxxxxxxxxxxxxx
> >> *Betreff: **[ecd-pmc] PMC Approval required for Committer Election 
> >> for
> >> Igor Vinokur on Eclipse Theia*
> >> *Datum: *10. Juni 2019 um 06:01:12 MESZ
> >> *An: *ecd-pmc PMC List <ecd-pmc@xxxxxxxxxxx>
> >> *Kopie: *Eclipse Theia Dev List <theia-dev@xxxxxxxxxxx>
> >> *Antwort an: *Eclipse cloud development PMC discussions <
> >> ecd-pmc@xxxxxxxxxxx>
> >>
> >> The Committer Election for Igor Vinokur on project Eclipse Theia
> >> (ecd.theia)
> >> concluded successfully.
> >>
> >> PMC leads and members can click the election link below to review and
> >> approve.
> >>
> >> Election:
> >>
> >> https://projects.eclipse.org/projects/ecd.theia/elections/election-igor-vinokur-committer-eclipse-theia
> >>
> >> Project: https://projects.eclipse.org/projects/ecd.theia
> >>
> >> _______________________________________________
> >> ecd-pmc mailing list
> >> ecd-pmc@xxxxxxxxxxx
> >> To change your delivery options, retrieve your password, or 
> >> unsubscribe
> >> from this list, visit
> >> https://www.eclipse.org/mailman/listinfo/ecd-pmc
> >>
> >>
> >> _______________________________________________
> >> ecd-pmc mailing list
> >> ecd-pmc@xxxxxxxxxxx
> >> To change your delivery options, retrieve your password, or 
> >> unsubscribe
> >> from this list, visit
> >> https://www.eclipse.org/mailman/listinfo/ecd-pmc
> >>
> >
> >
> > -- 
> > Sven Efftinge
> >
> > TypeFox GmbH
> > Am Germaniahafen 1
> > 24143 Kiel
> >
> > Sitz: Kiel, Registergericht: Amtsgericht Kiel, HRB 17385
> > Managing Directors: Sven Efftinge, Moritz Eysholdt, Dr. Jan Köhnlein
> > _______________________________________________
> > ecd-pmc mailing list
> > ecd-pmc@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or 
> > unsubscribe from this list, visit
> > https://www.eclipse.org/mailman/listinfo/ecd-pmc
> _______________________________________________
> ecd-pmc mailing list
> ecd-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/ecd-pmc
> 
> 
> -- 
> Sven Efftinge
> 
> TypeFox GmbH
> Am Germaniahafen 1
> 24143 Kiel
> 
> Sitz: Kiel, Registergericht: Amtsgericht Kiel, HRB 17385
> Managing Directors: Sven Efftinge, Moritz Eysholdt, Dr. Jan Köhnlein
> 
> 
> -- 
> Sven Efftinge
> 
> TypeFox GmbH
> Am Germaniahafen 1
> 24143 Kiel
> 
> Sitz: Kiel, Registergericht: Amtsgericht Kiel, HRB 17385
> Managing Directors: Sven Efftinge, Moritz Eysholdt, Dr. Jan Köhnlein
> _______________________________________________
> ecd-pmc mailing list
> ecd-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/ecd-pmc