[ease-dev] Fixing up Sonar/FindBugs issues

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

Hi EASE-Dev team,

I am just coming to speed with EASE development and the code base. I
have found a good way to get familiar with it is to address rather
small issues to understand the code.

With EASE already set-up for Sonar/Findbugs it makes it easy to
identify some low hanging fruit.

In that vein I have already done Bug 477966 to address the only
Blocker item identified. I am also working on a few of the Critical
Performance ones too and they will be submitted soon.

I have a question which touches a little bit on code-style. The single
biggest issue (by count) is "Control structures should always use
curly braces". See
https://dev.eclipse.org/sonar/dashboard/index/27203?did=2 this single
issue accounts for approximately 1/2 of all issues that Sonar reports.

Would you be open to fixes that addressed this?

An example approach would be to work on the highest scoring files and
see if I can get them clean(er). At the moment
org.eclipse.ease.tools.ResourceTools and
org.eclipse.ease.AbstractScriptEngine are at the top of the list.

Any thoughts?

Thanks,
Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com