[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ease-dev] Fixing up Sonar/FindBugs issues
|
Hi Jonah,
great you are working on the project. Your help is appreciated!
I recently fixed the sonar build for ease.modules too, so there should
be more issues on the way :)
Regarding the curly braces issue:
Our current code style does not enforce using braces for single line
statements.
This reflects my personal taste and could of course start religion wars
as all code style settings.
Personally I prefer to avoid those brackets in clear cases as it keeps
the relevant code tighter.
On the other hand sometimes this might lead to errors when changing such
statements and adding code to them.
Looking on the internet you will find pros and cons for both sides.
I was trying to argue about the default sonar settings and trying to
adapt the default profile used for checkstyle but with no success so far.
But changing hundrets of braces will not help you to learn about the
framework, nor will it improve code quality. This would be a pure monkey
task to make sonar happy.
While I think this is of very little use I will not stop you doing this
if you really want to.
IMHO it would definitely be more helpful to look at 'real' issues and
weaknesses in the code.
Unit tests are always welcome too, as we have far too few of them. It is
also a good way to learn about the framework.
best regards
Christian
Am 23.09.2015 um 17:02 schrieb Jonah Graham:
Hi EASE-Dev team,
I am just coming to speed with EASE development and the code base. I
have found a good way to get familiar with it is to address rather
small issues to understand the code.
With EASE already set-up for Sonar/Findbugs it makes it easy to
identify some low hanging fruit.
In that vein I have already done Bug 477966 to address the only
Blocker item identified. I am also working on a few of the Critical
Performance ones too and they will be submitted soon.
I have a question which touches a little bit on code-style. The single
biggest issue (by count) is "Control structures should always use
curly braces". See
https://dev.eclipse.org/sonar/dashboard/index/27203?did=2 this single
issue accounts for approximately 1/2 of all issues that Sonar reports.
Would you be open to fixes that addressed this?
An example approach would be to work on the highest scoring files and
see if I can get them clean(er). At the moment
org.eclipse.ease.tools.ResourceTools and
org.eclipse.ease.AbstractScriptEngine are at the top of the list.
Any thoughts?
Thanks,
Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev
