Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [dtp-dev] Any chance to include an eclipse data tools patch for a severe issue?
Thanks to some assistance from akurtakov, DTP is once again green and building w/ Eclipse 4.11 and Tycho 1.3.


Let me know if you see any unexpected issues due to the refactoring I had to do to move up to Eclipse 4.11.


Nick

On Mon, Jan 7, 2019 at 9:48 AM Patric Rufflar <patric@xxxxxxxxxxx> wrote:

Hi Nick,

I don't see any relationship between the compile errors and my patch.
(and the error occurs at a completely different module).

Patric

On 07.01.2019 15:39, Nick Boldt wrote:

Yes, it would be part of the Eclipse sim rel 2019-03 train.
 
However, the gerrit failed to compile and subsequent local tests have also failed. Not sure if this is a platform issue (swt 32-bit was dropped in Eclipse 4.10) or something more sinister.
 
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.3.0:compile (default-compile) on project org.eclipse.datatools.sqltools.sqlbuilder: Compilation failure: Compilation failure: 
[ERROR] updateTreeViewer.setInput(input);
[ERROR]                  ^^^^^^^^
[ERROR] The method setInput(Object) is undefined for the type UpdateTreeViewer
[ERROR] updateTreeViewer.setInput(null);
[ERROR]                  ^^^^^^^^
[ERROR] The method setInput(null) is undefined for the type UpdateTreeViewer
[ERROR] updateTreeViewer.addSelectionChangedListener(this);
[ERROR]                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
If I can figure out why this no longer compiles, and fix it, I'll push your patch into master.
 
Anyone on dtp-dev@ want to offer some help?
 
Nick
 

On Sat, Jan 5, 2019 at 7:57 PM Patric Rufflar <patric@xxxxxxxxxxx> wrote:
Hi Nick,

that're great news, thank you!
If it makes to DTP 1.14.104, will it be part of the next official eclipse release?

Cheers,
Patric


Am 04.01.2019 um 19:26 schrieb Nick Boldt:
> Wow, that patch is nearly 2 years old.
>
> I've converted it to a gerrit request. DTP isn't on github, it's on
> git.eclipse.org <http://git.eclipse.org>.
>
> Here's the gerrit:
>
> https://git.eclipse.org/r/#/c/134663/
>
> And here's the test-build:
>
> https://ci.eclipse.org/datatools/job/org.eclipse.datatools-gerrit_master/16/
>
> If that passes and no one objects to the change (this list is mostly ignored
> these days) I can merge it into DTP 1.14.104.
>
>
> On Fri, Jan 4, 2019 at 11:36 AM Patric Rufflar <patric@xxxxxxxxxxx
> <mailto:patric@xxxxxxxxxxx>> wrote:
>
>     Hi Nick,
>
>     do you see any chance to commit the patch for eclipse data tools bug?
>     https://bugs.eclipse.org/bugs/show_bug.cgi?id=412269
>
>     (patch attached in the bugzilla).
>
>     The patch will fix ODA XML xpath handling which uses a filter clause
>     which is broken since years.
>     I would submit a PR, but unfortunately datatools project seems to be not
>     on github.
>
>     Thanks,
>     - Patric
>
>
>
> --
>
> Nick Boldt
>
> Principal Software Engineer, RHCSA
>
> Productization Lead :: JBoss Tools & Dev Studio
>
> IM: @nickboldt / @nboldt / http://nick.divbyzero.com
>
> <https://red.ht/sig> 
> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
>
> @ @redhatnews <https://twitter.com/redhatnews>    Red Hat
> <https://www.facebook.com/RedHatInc>
> <https://www.facebook.com/RedHatInc>
>
>
> "The Only Thing That Is Constant Is Change" - Heraclitus

 
--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com
 
 
"The Only Thing That Is Constant Is Change" - Heraclitus

 

 


--

Nick Boldt

Principal Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com



“The Only Thing That Is Constant Is Change” - Heraclitus

Back to the top