Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[dsdp-tm-dev] RC1 Code Review - Encodings 
Hi Kushal,

I reviewed yesterday's changes and I have some questions
and requests:

* Host / IHost
  You updated Javadoc: For methods declared on interfaces,
  please put documentation on the interface ONLY. There
  is no use in duplicating the docs to the implementation,
  since it is designed to do exactly what the interface requires
  anyways.
  Please get rid of the new Javadoc on Host.getEncoding(), and
  fix the parameter "checkRemote" into "fromRemote

* IRemoteCmdSubSystem:
  You added a breaking API change. This is OK, but I documented
  it on https://bugs.eclipse.org/bugs/show_bug.cgi?id=179937
  and added info about it to the build notes.

* SubSystemConfigurationAdapter:
  Should we deprecate 
    SubSystemConfigurationAdapter.getChangeFilterAction()
    SystemChangeFilterAction
  I don't really see what they are still used for.
  https://bugs.eclipse.org/bugs/show_bug.cgi?id=143157

Can you please answer and/or address these.

Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm

Back to the top