Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[dsdp-tm-dev] RC1 Code Review

Hi Michael,

I reviewed your code changes for 
And I have some questions:

1. You store the RuntimeException inside fException
   and if one exists, the connector is treated as
   initialized. Should there perhaps be a mechanism
   that allows for dynamic reconfiguring, i.e. fixing
   a not installed problem? This might be worth a 
   separate bug entry for the future.

2. You seem to be wrapping the RuntimeException 
   inside another RuntimeException, doesn't this
   hide the embedded message for later processing
   in TerminalControl?

1. When displaying the RuntimeException, is it guaranteed
   that all exceptions have a message? I often do this:

   String msg = e.getMessage();
   if (msg==null) msg = e.getClass().getName();

Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member

Back to the top