[dsdp-tm-dev] Re: RC1 Code Review - Encodings

[Kushal Munir <kmunir@xxxxxxxxxx>]

Hi Martin,

See my responses below...

Kushal Munir
System i Team Collaboration Tools
IBM Toronto Lab, 8200 Warden Ave., Markham, ON
Phone: (905) 413-3118
Email: kmunir@xxxxxxxxxx



                                                                           
             "Oberhuber,                                                   
             Martin"                                                       
             <Martin.Oberhuber                                          To 
             @windriver.com>           Kushal Munir/Toronto/IBM@IBMCA      
                                                                        cc 
             05/25/2007 07:39          "Target Management developer        
             AM                        discussions"                        
                                       <dsdp-tm-dev@xxxxxxxxxxx>           
                                                                   Subject 
                                       RC1 Code Review - Encodings         
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




Hi Kushal,

I reviewed yesterday's changes and I have some questions
and requests:

* Host / IHost
  You updated Javadoc: For methods declared on interfaces,
  please put documentation on the interface ONLY. There
  is no use in duplicating the docs to the implementation,
  since it is designed to do exactly what the interface requires
  anyways.
  Please get rid of the new Javadoc on Host.getEncoding(), and
  fix the parameter "checkRemote" into "fromRemote

KM>> Done.

* IRemoteCmdSubSystem:
  You added a breaking API change. This is OK, but I documented
  it on https://bugs.eclipse.org/bugs/show_bug.cgi?id=179937
  and added info about it to the build notes.

KM>> Thanks!

* SubSystemConfigurationAdapter:
  Should we deprecate
    SubSystemConfigurationAdapter.getChangeFilterAction()
    SystemChangeFilterAction
  I don't really see what they are still used for.
  https://bugs.eclipse.org/bugs/show_bug.cgi?id=143157

KM>> SubSystemConfigurationAdapter.getChangeFilterAction() is called to get
the change action which is then used to get the change dialog which is
ultimately used for settings in the filter property page. I think we should
make them deprecated so we can remove them in the future, but it does mean
that we'll be using the deprecated method and class in our code. Is that
ok?

Can you please answer and/or address these.

Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm