[dsdp-tm-dev] Re: RC1 Code Review - Encodings
See my responses below...
System i Team Collaboration Tools
IBM Toronto Lab, 8200 Warden Ave., Markham, ON
Phone: (905) 413-3118
@windriver.com> Kushal Munir/Toronto/IBM@IBMCA
05/25/2007 07:39 "Target Management developer
RC1 Code Review - Encodings
I reviewed yesterday's changes and I have some questions
* Host / IHost
You updated Javadoc: For methods declared on interfaces,
please put documentation on the interface ONLY. There
is no use in duplicating the docs to the implementation,
since it is designed to do exactly what the interface requires
Please get rid of the new Javadoc on Host.getEncoding(), and
fix the parameter "checkRemote" into "fromRemote
You added a breaking API change. This is OK, but I documented
it on https://bugs.eclipse.org/bugs/show_bug.cgi?id=179937
and added info about it to the build notes.
Should we deprecate
I don't really see what they are still used for.
KM>> SubSystemConfigurationAdapter.getChangeFilterAction() is called to get
the change action which is then used to get the change dialog which is
ultimately used for settings in the filter property page. I think we should
make them deprecated so we can remove them in the future, but it does mean
that we'll be using the deprecated method and class in our code. Is that
Can you please answer and/or address these.
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member