[dsdp-tm-dev] Re: RSE classfileparser to be "internal"?

[Kushal Munir <kmunir@xxxxxxxxxx>]

Hi Martin,

Regarding the Java class file parser package, those classes, except two,
should definitely not be public API. I've refactored them:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=180606. The two classes
BasicClassFileParser and ClassFileUtil are used by other plugins, and I've
kept them as public.

Cheers,

Kushal Munir
Websphere Development Studio Client for iSeries
IBM Toronto Lab, 8200 Warden Ave., Markham, ON
Phone: (905) 413-3118        Tie-Line: 969-3118
Email: kmunir@xxxxxxxxxx



                                                                           
             "Oberhuber,                                                   
             Martin"                                                       
             <Martin.Oberhuber                                          To 
             @windriver.com>           Kushal Munir/Toronto/IBM@IBMCA      
                                                                        cc 
             04/02/2007 11:01          "Target Management developer        
             AM                        discussions"                        
                                       <dsdp-tm-dev@xxxxxxxxxxx>           
                                                                   Subject 
                                       RSE classfileparser to be           
                                       "internal"?                         
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




Hi Kushal and all,

When browsing rse.doc.isv, I noticed that

org.eclipse.rse.services/clientserver/
   org.eclipse.rse.services.clientserver.java

contains a Java class file parser which is
entirely public API. Do we really want this
to be public API?

Similarly,
   org.eclipse.rse.services.clientserver.processes.handler
contains process handler implementations for
various OS's. Should these really be public API?
I'd reckon that these should rather be internal.
Also, they "implement"
   ISystemProcessRemoteConstants
which we've declared deprecated practice (constance should
be referenced directly instead).

Comment here on the mailing list please!

Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm