[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cross-project-issues-dev] End of Era: p2.statsURI and p2.mirrorsURL editing

Hi Ed

Thanks.

So my pragmatic approach to put p2 properties in all S builds would be bad.

Your (EMF, OOMPH) solution makes you a 'very bad person' for using an internal.

What is the recommended approach? What do other projects do?

In the absence of an EF solution better than the old use of vi, I'm inclined just to augment my N/I/S builds by an R build that builds directly for the target location with p2 properties. This will of course ignore the hide-until-GA rule.

ÂÂÂ Regards

ÂÂÂ ÂÂÂ Ed Willink

On 02/09/2019 07:23, Ed Merks wrote:
Ed,

When p2 downloads the artifacts it will use the mirrorsURL of the repo to create the URI that's used to download the artifact. If nothing exists at that location, I'm quite sure that download will fail.

So yes, imagine that having the milestone repo specify a mirrorsURL applicable for the non-existent release repo is going to cause a problem.

Likely best is that you create a promotion job that automates everything you were doing manually. That's likely also less error prone. This is exactly what EMF's build job does for a release build, i.e., it takes the most recent milestone build and "mirrors" it to the proper location for a release, setting the mirrorsURL property appropriate for that target location. And when I say "mirrors", it literally uses org.eclipse.equinox.p2.internal.repository.tools.MirrorApplication, so there is no editing of files involved.

https://git.eclipse.org/c/emf/org.eclipse.emf.git/tree/releng/org.eclipse.emf.releng/src/org/eclipse/emf/releng/UpdateSiteGenerator.java#n174


Of course MirrorApplication is internal so I'm a very bad person for using it...



On 02.09.2019 06:50, Ed Willink wrote:
Ping. Anyone?

On 28/08/2019 19:14, Ed Willink wrote:
Hi

My prevailing practice is/was to publish the final RC as the release once the quiet 'week' is progressing without hiccoughs. This requires some 'simple' copies and renames from a milestones tree to the release tree. It was also necessary to use ssh and vi to edit the artifacts.jar to add p2.statsURI and p2.mirrorsURL properties manually.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=341744 has been fixed so that Tycho can now auto-generate p2.statsURI and p2.mirrorsURL properties in artifacts.jar; thanks guys.

But Tycho auto-generates at build time rather than edits during quiet 'week' publish-time. The simplest solution is to add the p2.statsURI and p2.mirrorsURL to all stable builds, rather than do a new release build during the quiet 'week'.

Question: will the p2.statsURI and p2.mirrorsURL properties break P2 milestone repos if milestone builds have these properties with values applicable to the published release?

ÂÂÂ Regards

ÂÂÂ ÂÂÂ Ed Willink


--- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________
cross-project-issues-dev mailing list
cross-project-issues-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev