[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[cdt-patch] Warnings in conflicting files are marked as errors
|
Hello folks,
I discovered that any messages produced in source files with name
conflicts are always treated as errors, even if they are only compiler
warnings. Find details and an example in
https://bugs.eclipse.org/bugs/show_bug.cgi?id=108920
I also propose a bugfix. The required patch is attached. I trust that
this is a minor fix so I am rushing through the necessary steps and
present the bug report and solution at the same time.
Any comments on this, or can it be applied?
Norbert Ploett
Index: D:/Projekt/RTP/Work3.1/org.eclipse.cdt.core/src-cdtcore/org/eclipse/cdt/internal/errorparsers/GCCErrorParser.java
===================================================================
--- D:/Projekt/RTP/Work3.1/org.eclipse.cdt.core/src-cdtcore/org/eclipse/cdt/internal/errorparsers/GCCErrorParser.java (revision 100)
+++ D:/Projekt/RTP/Work3.1/org.eclipse.cdt.core/src-cdtcore/org/eclipse/cdt/internal/errorparsers/GCCErrorParser.java (working copy)
@@ -231,7 +231,7 @@
IFile file = eoParser.findFileName(fileName);
if (file != null) {
if (eoParser.isConflictingName(fileName)) {
- desc = "[Conflicting names: " + fileName + " ] " + desc; //$NON-NLS-1$ //$NON-NLS-2$
+ desc = desc + " [Conflicting names]"; //$NON-NLS-1$
file = null;
}
} else {
@@ -248,7 +248,7 @@
file = eoParser.findFileName(fileName);
if (file != null) {
if (eoParser.isConflictingName(fileName)) {
- desc = "[Conflicting names: " + name + " ] " + desc; //$NON-NLS-1$ //$NON-NLS-2$
+ desc = desc + " [Conflicting names]"; //$NON-NLS-1$ //$NON-NLS-2$
file = null;
}
}
