Re: [cdt-dev] Patch for review

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

Thanks Davin for the ping. Sorry that such pinging is sometimes necessary to bring things to the top of our lists again, but I have now reviewed your change and thank you for providing it.

For Davin and everyone else, the pinging of code reviews is part of CDT's process, so don't feel bad doing the pinging. Ideally some feedback would go to people as soon as possible, but sometimes things come up. I (and I hope all the other CDT committers) will continue to strive to continuously be better in this regard.

If it has not received attention in a week or so, some nagging can help. Send email to mailto:cdt-dev@xxxxxxxxxxx asking committers to look at the contribution. Continue sending e-mails until somebody would give up and look :)

Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

On Fri, 24 Jun 2022 at 18:52, Davin McCall <davmac@xxxxxxxxxx> wrote:

Hi all,

Would anyone be able to review my patch, here:
https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/194282

This is for bug 580201, "constexpr evaluation of builtins doesn't narrow integer arguments", and builds on the work I did earlier to support constexpr evaluation of various builtins for the last release.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=580201

Thanks,

Davin

_______________________________________________
cdt-dev mailing list
cdt-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cdt-dev