Re: RE: [cdt-dev] FYI, merged in a bunch of changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: RE: [cdt-dev] FYI, merged in a bunch of changes

From: Chris Recoskie <recoskie@xxxxxxxxxx>
Date: Thu, 13 May 2010 10:04:47 -0400
Delivered-to: cdt-dev@xxxxxxxxxxx
List-archive: <https://dev.eclipse.org/mailman/private/cdt-dev>
List-help: <mailto:cdt-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/cdt-dev>, <mailto:cdt-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/listinfo/cdt-dev>, <mailto:cdt-dev-request@eclipse.org?subject=unsubscribe>

I posted a patch that hopefully addresses your concerns. Please let me know what you think of it.

===========================
Chris Recoskie
Team Lead, IBM CDT and RDT
IBM Toronto

Sergey Prigogin ---05/12/2010 06:19:40 PM---On Wed, May 12, 2010 at 3:08 PM, Chris Recoskie <recoskie@xxxxxxxxxx> wrote: > Ok...

From:	Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>
To:	"CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date:	05/12/2010 06:19 PM
Subject:	Re: RE: [cdt-dev] FYI, merged in a bunch of changes
Sent by:	cdt-dev-bounces@xxxxxxxxxxx

On Wed, May 12, 2010 at 3:08 PM, Chris Recoskie <recoskie@xxxxxxxxxx> wrote:

Ok...

I would suggest any specific feedback you have, you should post to

https://bugs.eclipse.org/bugs/show_bug.cgi?id=291815

, which is where the original contribution and discussion of this API was done.

Done.

===========================
Chris Recoskie
Team Lead, IBM CDT and RDT
IBM Toronto

Sergey Prigogin ---05/12/2010 06:04:04 PM---On Wed, May 12, 2010 at 2:59 PM, Chris Recoskie <

recoskie@xxxxxxxxxx

> wrote: > I understand the chan

From:	Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>
To:	"CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date:	05/12/2010 06:04 PM
Subject:	Re: RE: [cdt-dev] FYI, merged in a bunch of changes
Sent by:	cdt-dev-bounces@xxxxxxxxxxx

On Wed, May 12, 2010 at 2:59 PM, Chris Recoskie <

recoskie@xxxxxxxxxx

> wrote:

I understand the changes you are suggesting, but what I'm not sure I understand is whether you are saying that the interfaces should not go in at all until these things are resolved, or whether the interfaces stay in but don't get modified to incorporate your suggestions until later.

The interface should not go in in its current form.

The APIs are all provisional. They can be changed as needed. I'm pretty sure IBM is the only client of them right now. If there are improvements that can be made to the API or the documentation surrounding them I am happy to make them.

We have our new version of our product coming out in the fall that is going to be based on Helios, so I will need those changes in time for that. We won't be able to wait until the next simultaneous release in 2011 for them.

===========================
Chris Recoskie
Team Lead, IBM CDT and RDT
IBM Toronto

-sergey

Sergey Prigogin ---05/12/2010 05:31:21 PM---IFilesystemUtility interface requires serious work in terms of writing clear unambiguous specificati

From:	Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx>
To:	"CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date:	05/12/2010 05:31 PM
Subject:	Re: RE: [cdt-dev] FYI, merged in a bunch of changes
Sent by:	cdt-dev-bounces@xxxxxxxxxxx

IFilesystemUtility interface requires serious work in terms of writing clear unambiguous specifications for all its methods and, possibly, changing method names to match those descriptions. The name of the interface should be more specific. A capitalization mismatch between IFilesystemUtility and FileSystemUtility has to be fixed. A prudent thing to do is to postpone these changes until after 7.0.

-sergey

On Wed, May 12, 2010 at 2:14 PM, Chris Recoskie <

recoskie@xxxxxxxxxx

> wrote:

Well I need some direction on what is the solution.

Do I need to port FilesystemUtilityManager, etc. to 6.0.x as well? Or is it enough for the since tags to be 5.2? Or what exactly?

===========================
Chris Recoskie
Team Lead, IBM CDT and RDT
IBM Toronto

Doug Schaefer ---05/12/2010 11:01:08 AM---Chris, I understand what you are trying to do, but your commit is clearly in violation of our CDT 7.

From:	Doug Schaefer <cdtdoug@xxxxxxxxx>
To:	"CDT General developers list." <cdt-dev@xxxxxxxxxxx>
Date:	05/12/2010 11:01 AM
Subject:	Re: RE: [cdt-dev] FYI, merged in a bunch of changes
Sent by:	cdt-dev-bounces@xxxxxxxxxxx

Chris, I understand what you are trying to do, but your commit is clearly in violation of our CDT 7.0 guidelines and I need to join in the requests to either bring it into alignment or have it withdrawn. We are trying to rid ourselves of the sins of the past. I hope you understand.

Doug.