Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [cbi-dev] Rebasing CBI to M5

Thanks Paul,

 

Some more questions, so I had a look at the R4 repository map files. They don't seem to indicate which tags for each repository was used to build like the R3 ones did. Instead I see things like the following:

 

feature@xxxxxxxxxxxxxxx=p2IU,id=org.eclipse.jdt.feature.jar,repository=ECLIPSE_PLATFORM_REPO

 

Which seems to point to jar files instead. I tried checking out eclipse.jdt.git tag I20120301-2200 as well but it seems that tag doesn't exist. I guess for R4 how do I know which tags were used for each repository?

 

 

Thanh



-----Original Message-----
From: Paul Webster <pwebster@xxxxxxxxxxxxxxxxxxx>
Sent: March 6, 2012 01:10 PM
To: Common-build Developers discussion <cbi-dev@xxxxxxxxxxx>
Cc:
Subject: Re: [cbi-dev] Rebasing CBI to M5

On Tue, Mar 6, 2012 at 12:39 PM, Thanh Ha <thanh.ha@xxxxxxxxxxx> wrote:

Hi Everyone,

 

Going through the map files today and saw something that has me a bit confused and hoping someone can explain it to me to make it more clear. What I noticed was the map files for the various repositories don't seem to map consistently to tags. For example looking at eclipse.jdt.debug.git repository:

 

% grep "eclipse.jdt.debug.git" *

jdtdebug.map:plugin@xxxxxxxxxxxxxxx.debug=GIT,tag=v20120302-2319,repo=git://git.eclipse.org/gitroot/jdt/eclipse.jdt.debug.git,path=org.eclipse.jdt.debug

jdtdebug.map:plugin@xxxxxxxxxxxxxxxxxxxxxxxx=GIT,tag=v20120305-1601,repo=git://git.eclipse.org/gitroot/jdt/eclipse.jdt.debug.git,path=org.eclipse.jdt.debug.ui

jdtdebug.map:plugin@xxxxxxxxxxxxxxx.launching=GIT,tag=v20120301-0523,repo=git://git.eclipse.org/gitroot/jdt/eclipse.jdt.debug.git,path=org.eclipse.jdt.launching

jdtdebug.map:plugin@xxxxxxxxxxxxxxx.launching.macosx=GIT,tag=v20120301-0523,repo=git://git.eclipse.org/gitroot/jdt/eclipse.jdt.debug.git,path=org.eclipse.jdt.launching.macosx

jdtdebug.map:plugin@xxxxxxxxxxxxxxxxxxxxxxxxxxxx.macosx=GIT,tag=v20120119-2105,repo=git://git.eclipse.org/gitroot/jdt/eclipse.jdt.debug.git,path=org.eclipse.jdt.launching.ui.macosx

jdtdebug.map:plugin@xxxxxxxxxxxxxxx.debug.tests=GIT,tag=v20120302-2319,repo=git://git.eclipse.org/gitroot/jdt/eclipse.jdt.debug.git,path=org.eclipse.jdt.debug.tests

 

While I can see that each of them are pointing to different directories in the repositories, I'm a bit confused why each sub directory in the repository has a different tag referenced. I guess what I'm getting at is if I'm merging these into the CBI build it seems like I need to merge different tags in each repository on a per directory basis.



Right now we use PDE build plus those map files to manage build input, and a PDE fetch factory (from EGit).  This fetch factory copies the plugin or feature content into the PDE build work area <buildDir>/plugins (or features).  So right now it simply checks out each tag and then copies the plugin over.  With map files it's possible to pull in the plugins from one repo from any tag in that repo.

This is not consistent with how the prototype works, where the aggregator submodules capture the build input commit for each git repo.

But it's not as bad as it sounds.  By convention we use an auto-tagging script that derives all of the tags used in the PDE map files, on a repo by repo basis (in effect, that's the build input commit for that build).

In 4.2 we tag the build input commit on each repo with the build tag, I20120301-2200 for example.  For 3.8, you might have to do a little more detective work to determine the build input commit.



Later,
PW

--
Paul Webster
Hi floor.  Make me a sammich! - GIR



Back to the top