Re: [websocket-dev] PR reviews pending

[Mark Thomas <markt@xxxxxxxxxx>]

On 27/06/18 09:44, arjan tijms wrote:
> Hi,
> 
> I'm not sure if WebSocket has setup any specific rules like "always 3
> approved reviews, including your self", but if not I'd say you can
> self-approve and just merge it in.

It looks like the repo has been setup with specific rules that prevent
me doing that.

Looking at GitHub, I think any other committer is able to
review/approve. If you are able to review these that would be great. If
not, no worries.

My larger concern is that nothing has happened for the last month. I
think we need to get the review rules relaxed. If we continue with the
current process I'm concerned that the project will lose momentum and
find it hard to attract new contributors.

Mark



> You addressed 1 raised concern and explained another concern, then
> nobody objected in all that time. I'm not an authority on WebSocket in
> any way, but in the projects where I am this would mean it's okay to merge.
> 
> Just for clarity, the issues Mark refers to are these I think:
> 
> * https://github.com/eclipse-ee4j/websocket-api/pull/251
> * https://github.com/eclipse-ee4j/websocket-api/pull/253
> 
> Kind regards,
> Arjan
> 
> 
> 
> On Wed, Jun 27, 2018 at 8:03 AM Mark Thomas <markt@xxxxxxxxxx
> <mailto:markt@xxxxxxxxxx>> wrote:
> 
>     All,
> 
>     It has been over a month since I started this thread with no response on
>     the thread and no further comments on the PRs.
> 
>     Is there something blocking this I'm not aware of?
> 
>     Mark
> 
> 
>     On 30/05/18 08:51, Mark Thomas wrote:
>     > Ping...
>     >
>     > Mark
>     >
>     >
>     > On 22/05/18 14:15, Mark Thomas wrote:
>     >> Ping.
>     >>
>     >> I have two pretty basic PRs that have been waiting for
>     review/approval
>     >> for a month.
>     >>
>     >> Mark
>     >> _______________________________________________
>     >> websocket-dev mailing list
>     >> websocket-dev@xxxxxxxxxxx <mailto:websocket-dev@xxxxxxxxxxx>
>     >> To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     >> https://dev.eclipse.org/mailman/listinfo/websocket-dev
>     >>
>     >
>     > _______________________________________________
>     > websocket-dev mailing list
>     > websocket-dev@xxxxxxxxxxx <mailto:websocket-dev@xxxxxxxxxxx>
>     > To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     > https://dev.eclipse.org/mailman/listinfo/websocket-dev
>     >
> 
>     _______________________________________________
>     websocket-dev mailing list
>     websocket-dev@xxxxxxxxxxx <mailto:websocket-dev@xxxxxxxxxxx>
>     To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     https://dev.eclipse.org/mailman/listinfo/websocket-dev
> 
> 
> 
> _______________________________________________
> websocket-dev mailing list
> websocket-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/websocket-dev
>