Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tracecompass-dev] Hello

Hi!
I wanted to try to set up my git and gerrit account to be able to push
changes - I have actually just chosen one occurence of a null type
safety warning that seems to be valid to me.
But gerrit does not allow me to push my commit. I have signed the CLA,
installed the hook and put my "Signed-off-by" signature in the commit
message. Still I must have missed something...
Any hints?
Thanks,
  Florian.

2016-05-01 0:19 GMT+02:00 Florian Mösch <florian@xxxxxxxxxx>:
> Hi Patrick,
> thanks for your feedback. I have indeed noticed that different
> matching lines can define different fields. That helps a bit but
> unfortunately, the table view will grow huge if you need to extract
> different information from many different events...
> On the other hand, it looks like writing your own "real" parsers is
> not that difficult and maybe a more suitable way to go.
> Anyway: I think it would help a lot if different root lines could
> generate different event types or different parsers could on the other
> hand generate the same event types. I'll have a look at the code and
> see if I can make a proposal for e change. But first, I'll continue to
> work on my first own parser.
> Regarding the null-pointer safety warnings, I have meanwhile read
> about some of the limitations that lead to many false warnings: the
> compiler should know that AnyObject.class is NonNull e.g. But I think,
> I've also see a couple of warnings that seem to make sense.
> I'll check if I see some that could or should be fixed.
> Best regards,
>   Florian.


Back to the top