Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tracecompass-dev] Moving plugins to component sub-directories

oops. I thought this was going to alex direct. Pardon my French ;)

Translation: I was asking if we can review this on Monday.

On 15-06-12 09:29 AM, Matthew Khouzam wrote:
> Est-ce que ca te froisse trop si c'est apres que Bernd revienne (lundi?)
>
> On 15-06-12 03:15 AM, Alexandre Montplaisir wrote:
>> The latest version of the branch is now on Gerrit, rebased on master,
>> and successfully built on Hudson.
>>
>> If there are no objections, I will push it to the tree later today. It
>> is easier to push it all at once, so that people don't have to re-load
>> their workspace many times.
>>
>> Cheers,
>> Alex
>>
>>
>> On 2015-06-09 09:45 PM, Alexandre Montplaisir wrote:
>>> Alright so RC4 was released today (thanks Bernd!), so now we should
>>> not need to cherry-pick patches to the stable branch anymore.
>>>
>>> I have pushed the whole branch on Gerrit, this moves all the plugins
>>> in new directories at the top-level:
>>>
>>> analysis/
>>> btf/
>>> common/
>>> ctf/
>>> doc/
>>> gdbtrace/
>>> lttng/
>>> pcap/
>>> rcp/
>>> releng/
>>> statesystem/
>>> tmf/
>>>
>>> The git tree now looks much nicer! :)
>>>
>>> I'll start rebasing my other branches on top of this move, would be
>>> nice if we could get it in quickly and rebase new patches on top of
>>> it. I'll offer to take care of the rebase of any patch if you want,
>>> just ping me, it's actually very easy to do. Whereas rebasing this
>>> branch on top of a new master can be slightly more involving.
>>>
>>> Cheers,
>>> Alex
>>>
>>>
>>>
>>> On 2015-05-06 05:24 PM, Bernd Hufmann wrote:
>>>> Hi Alex
>>>>
>>>> sounds good to me.
>>>>
>>>> Cheers
>>>> Bernd
>>>>
>>>>
>>>> On 05/05/2015 04:50 PM, Alexandre Montplaisir wrote:
>>>>> Alright, since renaming the feature plugins to "*.feature" is less
>>>>> popular than I expected, we can drop this part.
>>>>>
>>>>> Marc-André suggested on the Gerrit review to name the intermediate
>>>>> Maven artifacts "-parent", so "org.eclipse.tracecompass.btf-parent"
>>>>> and so on. This seems like a good approach, independently of how
>>>>> the feature artifacts are called.
>>>>>
>>>>> I will prepare the patches for btf/, pcap/, and start experimenting
>>>>> with ctf/ to see how to handle the paths to the test traces and
>>>>> whatnot. But none of this is to go in 1.0, and will wait until
>>>>> stable-1.0 is branched off.
>>>>>
>>>>> Sounds good?
>>>>>
>>>>> Cheers,
>>>>> Alex
>>>>>
>>>>>
>>>>> On 2015-05-04 07:02 PM, Alexandre Montplaisir wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> I'm currently looking at moving all plugin directories in the
>>>>>> source tree to separate "component" directories. Like was done for
>>>>>> doc/ already, so that eventually top-level would only contain:
>>>>>>
>>>>>> btf/
>>>>>> ctf/
>>>>>> doc/
>>>>>> lttng/
>>>>>> tmf/
>>>>>> ...
>>>>>>
>>>>>> Some are not immediately clear where they should go (examples,
>>>>>> releng-site,...) but we'll see once we get there. ;)
>>>>>>
>>>>>> I started with the BTF component, since it's quite simple and
>>>>>> standalone:
>>>>>> https://git.eclipse.org/r/#/c/47104/
>>>>>> https://git.eclipse.org/r/#/c/47105/
>>>>>>
>>>>>> As explained in the first patch, I've renamed the feature plugins
>>>>>> to "*.feature". We've talked about adding the ".feature" to
>>>>>> feature plugin names previously, this is a good occasion to do so,
>>>>>> since it will free the o.e.t.{btf|ctf|...} names for the
>>>>>> directories themselves. I've added the previous names to the
>>>>>> p2.inf files, so that upgrades should follow the rename.
>>>>>>
>>>>>> Is there anything else that could have slipped my mind?
>>>>>>
>>>>>> I'm quite certain that this won't be all done in time for the
>>>>>> feature freeze, as more complex plugins with test traces and such
>>>>>> will take more time. Are we fine with just btf/ and pcap/ in 1.0,
>>>>>> and the rest later once stable-1.0 is branched?
>>>>>>
>>>>>>
>>>>>> Cheers,
>>>>>> Alexandre
>>>>>> _______________________________________________
>>>>>> tracecompass-dev mailing list
>>>>>> tracecompass-dev@xxxxxxxxxxx
>>>>>> To change your delivery options, retrieve your password, or
>>>>>> unsubscribe from this list, visit
>>>>>> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
>>>>> _______________________________________________
>>>>> tracecompass-dev mailing list
>>>>> tracecompass-dev@xxxxxxxxxxx
>>>>> To change your delivery options, retrieve your password, or
>>>>> unsubscribe from this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
>>>>
>>>> _______________________________________________
>>>> tracecompass-dev mailing list
>>>> tracecompass-dev@xxxxxxxxxxx
>>>> To change your delivery options, retrieve your password, or
>>>> unsubscribe from this list, visit
>>>> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
>>> _______________________________________________
>>> tracecompass-dev mailing list
>>> tracecompass-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or
>>> unsubscribe from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
>> _______________________________________________
>> tracecompass-dev mailing list
>> tracecompass-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or
>> unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
> _______________________________________________
> tracecompass-dev mailing list
> tracecompass-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev



Back to the top