Re: [tracecompass-dev] Moving plugins to component sub-directories

[Alexandre Montplaisir <alexmonthy@xxxxxxxxxxxx>]

Hi Bernd,

On 2015-05-05 12:55 PM, Bernd Hufmann wrote:
> Hi Alex
>
> Sorry, I'm against changing the feature ID to add .feature for 3 
> reasons. First of all, it's not correct that this change is more 
> inline with rest of Eclipse. For example the platform uses 
> org.eclipse.platform as feature ID, CDT uses org.eclipse.cdt or JGIT 
> uses org.eclipse.jgit, I also remember that there was big push to 
> align our feature-ids to that back in Linux Tools where all the 
> features had .features a suffix.

From the link you provided listing Platform features:
http://download.eclipse.org/eclipse/updates/4.5milestones/S-4.5M7-201504301445/features/

26 out of 64 have "feature" in their name. So it's not enforced or 
anything, but it seems common enough.

The goal was just to have new name for the feature plugins. ".feature" 
sounded like a good choice, because it's commonly used elsewhere, more 
than "-feature" in any case.

> Secondly, I'm against it because for me it is risky to do such a 
> change at that time of the simultaneous release. As in my experience, 
> such a change will cause some issues at one point because something 
> was overseen for testing. And lastly, I don't think we gain anything. 
> At least I don't see any advantages.
>
> About the sub-directories changes, I would prefer that this is done 
> after the Mars release because it would impact every developer's 
> development environment and all the existing patches on Gerrit patches 
> would have to be rebased.

I picked btf/ and pcap/ because I know these are very low traffic, so 
less chance of merge conflicts. I would have liked to have it done 
earlier rather than later, but there's indeed no important reason for it 
to be in 1.0. I'd be fine waiting for after we branch stable-1.0.


Cheers,
Alex

> Best Regards
> Bernd
>
> On 05/04/2015 07:02 PM, Alexandre Montplaisir wrote:
> > Hi all,
> >
> > I'm currently looking at moving all plugin directories in the source 
> > tree to separate "component" directories. Like was done for doc/ 
> > already, so that eventually top-level would only contain:
> >
> > btf/
> > ctf/
> > doc/
> > lttng/
> > tmf/
> > ...
> >
> > Some are not immediately clear where they should go (examples, 
> > releng-site,...) but we'll see once we get there. ;)
> >
> > I started with the BTF component, since it's quite simple and 
> > standalone:
> > https://git.eclipse.org/r/#/c/47104/
> > https://git.eclipse.org/r/#/c/47105/
> >
> > As explained in the first patch, I've renamed the feature plugins to 
> > "*.feature". We've talked about adding the ".feature" to feature 
> > plugin names previously, this is a good occasion to do so, since it 
> > will free the o.e.t.{btf|ctf|...} names for the directories 
> > themselves. I've added the previous names to the p2.inf files, so 
> > that upgrades should follow the rename.
> >
> > Is there anything else that could have slipped my mind?
> >
> > I'm quite certain that this won't be all done in time for the feature 
> > freeze, as more complex plugins with test traces and such will take 
> > more time. Are we fine with just btf/ and pcap/ in 1.0, and the rest 
> > later once stable-1.0 is branched?
> >
> >
> > Cheers,
> > Alexandre
> > _______________________________________________
> > tracecompass-dev mailing list
> > tracecompass-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or 
> > unsubscribe from this list, visit
> > https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
>
> _______________________________________________
> tracecompass-dev mailing list
> tracecompass-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev