Re: [tracecompass-dev] ControlFlowView - TimeGraphFilterDialog - Uncheck

["christian mansky" <christian.mansky@xxxxxx>]

  Hi Patrick.
Thank you for elaborating your concerns. Option one was what I had in mind. The toggle button shouldn't be too hard to do either ... however, how do you feel about a second button 'check active'?
Does it get too crowded?
Regards chris

Patrick Tasse <patrick.tasse@xxxxxxxxx>schrieb:

If I interpret correctly my old comments, I think it was that since this concept of active/inactive means something different for each view, and perhaps does not apply at all for some time graph views, I wanted it to be optional in the dialog.

That being said, what would a user prefer:

1-Open the dialog and apply a filter, the inactive entries at that current time range are hidden, and then browsing through the trace only shows the entries that were active when the filter was applied

or

2-Push a toggle button, and then the view automatically filters in/out dynamically the active/inactive entries in the current range as the user browses through the trace

Maybe the two options are not mutually exclusive...

We also have to worry about arrows to/from hidden entries, but I think the issue already exists with the current filter dialog.

Patrick

On Fri, Feb 27, 2015 at 9:36 AM, Geneviève Bastien <gbastien+lttng@xxxxxxxxxxxx> wrote:

Hi Chris,

A patch like that has already been proposed last year here:
https://git.eclipse.org/r/#/c/19262/

If I recall, apart from the review comments, it was dismissed back then
because the filter dialog was meant to be replaced by a new filter API
that will be much more flexible and universal for all views. But that is
yet to come, and in the meantime, if there is demand, this patch could
be ported to Trace Compass. And when the filter API arrives, it can then
be quietly removed from the code-base.

Cheers,
Genevieve

On 02/27/2015 08:12 AM, christian mansky wrote:
> Hi Everyone,
> I'd like to propose an enhancement to the ControlFlowView that affects the TimeGraphFilterDialog (the dialog where one can check and uncheck threads to be shown). I'd like to show 2 new Buttons saying 'Uncheck inactive' and 'Check active'. The idea is to select a time frame in the ControlFlowView to which the user wants to take a closer look. Upon selecting 'Uncheck inactive' all 'inactive' threads of this time frame are to be hidden (or all active threads to be shown, for that matter).
> A thread is considered active when in usermode, executing a syscall or when currently executing an interrupt. I realize the interesting part (architecture-wise) here is the abstraction of the ControlFlowView from the TimeGraphFilterDialog, or more specific, how the ControlFlowView presents its functionality to the TimeGraphFilterDialog.
>
> So before going into too many details, I'd like to know if this is something you consider a useful enhancement. I've seen something similar years ago in a scheduling viewer tool and came to appreciate it very much.
>
> Regards Chris.
> _______________________________________________
> tracecompass-dev mailing list
> tracecompass-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev

_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev

_______________________________________________ tracecompass-dev mailing list tracecompass-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/tracecompass-dev