[theia-dev] Commits when a PR is under Review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

[theia-dev] Commits when a PR is under Review

From: Thomas Mäder <tmader@xxxxxxxxxx>
Date: Wed, 16 Jun 2021 06:43:18 +0000
Delivered-to: theia-dev@xxxxxxxxxxx
List-archive: <https://www.eclipse.org/mailman/private/theia-dev/>
List-help: <mailto:theia-dev-request@eclipse.org?subject=help>
List-subscribe: <https://www.eclipse.org/mailman/listinfo/theia-dev>, <mailto:theia-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://www.eclipse.org/mailman/options/theia-dev>, <mailto:theia-dev-request@eclipse.org?subject=unsubscribe>
User-agent: eM_Client/8.2.1473.0

Hi folks,

In the community meeting yesterday, I mentioned that it makes sense to keep separate commits for fixups when a PR is under review, IMO. I've proposed a change to the PR rules here: https://github.com/eclipse-theia/theia/pull/9598

I don't expect this to be controversial, but since this is a change in the rules of engagement for the project, I don't want to sneak it in under the radar.

/Thomas

Prev by Date: [theia-dev] Nominations for project lead
Next by Date: Re: [theia-dev] Nominations for project lead
Previous by thread: [theia-dev] Nominations for project lead
Next by thread: [theia-dev] Monaco Upgrade Done
Index(es):
- Date
- Thread

Breadcrumbs