Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [sisu-users] Problem with the Sisu Extender

On 11 Sep 2013, at 09:16, gian.maria.romanato@xxxxxxxxxxxx wrote:
> Excellent, thanks for the contribution - I'll try to review your
> changes this week so they can be part of the upcoming release.


I updated the change on gerrit with a little improvement. Hope it is not a problem.

No worries, I've pushed the release back a bit because of other commitments and https://bugs.eclipse.org/bugs/show_bug.cgi?id=417319 (which delayed updates to the IP log)

> The extender bundle currently has no test coverage, that's another
> area which could do with some attention :)


I had a look at the tests project. It does not include the .project and .classpath file,
and as such I don't know if it supposed to be a PDE plug-in project or not.

You can import all modules into Eclipse as "existing Maven projects".

The main plug-in module uses Tycho so you can build it with Maven or Eclipse, use the "build.target" file from org.eclipse.sisu.inject to set the target platform.

Does your test automation system execute the tests in an OSGi container?

The tests module is currently a pure Maven project, but after this release I'm going to convert it to a Tycho-based test project:


Also, to test my extenders I normally use TinyBundles. Is TinyBundles available in your project dependencies?
If not, and assuming it is probably too late to include it, would you mind if the extender test
included one or two simple bundle JARs to install them in the container for testing the
extender?

TinyBundles is not available atm, we'd need to request use of it as a test-dependency (not a big deal, just have to follow the process at http://wiki.eclipse.org/Development_Resources/IP/Test_and_Build_Dependencies)

But Tycho's eclipse-test-plugin packaging should give us something similar, and it might be possible to also add TinyBundles to the mix to help script bundle events.

GianMaria.


Back to the top