| Re: [rdf4j-dev] Breaking change in latest minor release (4.3.0)? |
I have a simple reproducer test here: https://github.com/eclipse/rdf4j/pull/4578Any idea how to fix this?On Sat, May 20, 2023 at 8:38 PM Bart Hanssens (BOSA) via rdf4j-dev <rdf4j-dev@xxxxxxxxxxx> wrote:_______________________________________________Hmz, existing code should still work, the idea is to deprecate the settings in the helper packages (to be removed in 5.0),
and move them to parser-specific ones
Bart
From: rdf4j-dev <rdf4j-dev-bounces@xxxxxxxxxxx> On Behalf Of Erik Godding Boye
Sent: zaterdag 20 mei 2023 17:19
To: rdf4j developer discussions <rdf4j-dev@xxxxxxxxxxx>
Subject: Re: [rdf4j-dev] Breaking change in latest minor release (4.3.0)?
It seems like the classes are duplicated, and I think the relevant changes are in this PR: https://github.com/eclipse/rdf4j/pull/4332
No compiler error, but one of our tests were failing with the following error:
30261 [ERROR] verifyDatatypeReasoning Time elapsed: 0.026 s <<< ERROR!
java.lang.ClassCastException: class org.eclipse.rdf4j.rio.helpers.JSONLDMode cannot be cast to class org.eclipse.rdf4j.rio.jsonld.JSONLDMode (org.eclipse.rdf4j.rio.helpers.JSONLDMode and org.eclipse.rdf4j.rio.jsonld.JSONLDMode are in unnamed module of loader 'app')
at no.statnett.rdf4j.rio.DatatypeReasonerRDFHandlerTest.verifyDatatypeReasoning(DatatypeReasonerRDFHandlerTest.java:54)
On Sat, May 20, 2023 at 5:03 PM Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:
It’s a bit hard to read the diff in an email, but it looks like a package has moved?
-import org.eclipse.rdf4j.rio.helpers.JSONLDMode;
-import org.eclipse.rdf4j.rio.helpers.JSONLDSettings;
+import org.eclipse.rdf4j.rio.jsonld.JSONLDMode;
+import org.eclipse.rdf4j.rio.jsonld.JSONLDSettings;
Håvard
> On 20 May 2023, at 16:52, Erik Godding Boye <egboye@xxxxxxxxx> wrote:
>
>
> Hi all,
>
> In one of our projects, I had to modify code upgrading to rdf4j 4.3.0, see the patch below.
> Is that expected? It appears like a breaking change to me. 🤔
>
> Erik
>
> Subject: [PATCH] chore: upgrade rdf4j to version 4.3.0
>
> ---
> pom.xml | 2 +-
> src/test/java/no/statnett/rdf4j/utils/Writers.java | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/pom.xml b/pom.xml
> index d04aba1..ff31423 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -19,7 +19,7 @@
> <properties>
> <spring-boot.version>2.7.12</spring-boot.version>
> <graphdb.version>10.2.1</graphdb.version>
> - <rdf4j.version>4.2.4</rdf4j.version>
> + <rdf4j.version>4.3.0</rdf4j.version>
> <cxf.version>3.6.0</cxf.version>
>
> <graphdb.dist.folder>${project.build.directory}/graphdb-${graphdb.version}</graphdb.dist.folder>
> diff --git a/src/test/java/no/statnett/rdf4j/utils/Writers.java b/src/test/java/no/statnett/rdf4j/utils/Writers.java
> index fe450ab..03a2091 100644
> --- a/src/test/java/no/statnett/rdf4j/utils/Writers.java
> +++ b/src/test/java/no/statnett/rdf4j/utils/Writers.java
> @@ -4,8 +4,8 @@
> import org.eclipse.rdf4j.rio.RDFWriter;
> import org.eclipse.rdf4j.rio.Rio;
> import org.eclipse.rdf4j.rio.helpers.BasicWriterSettings;
> -import org.eclipse.rdf4j.rio.helpers.JSONLDMode;
> -import org.eclipse.rdf4j.rio.helpers.JSONLDSettings;
> +import org.eclipse.rdf4j.rio.jsonld.JSONLDMode;
> +import org.eclipse.rdf4j.rio.jsonld.JSONLDSettings;
>
> import java.net.URISyntaxException;
>
> --
> _______________________________________________
> rdf4j-dev mailing list
> rdf4j-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev
_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev