Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] Breaking change in latest minor release (4.3.0)?
  • From: "Bart Hanssens (BOSA)" <bart.hanssens@xxxxxxxxxxxx>
  • Date: Sat, 20 May 2023 18:38:35 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bosa.fgov.be; dmarc=pass action=none header.from=bosa.fgov.be; dkim=pass header.d=bosa.fgov.be; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nXVXLLyNZy/Sud/9mbc43vnc/Be3mNs2d97zgUIJfig=; b=A720YJ39a0T6sAUnFm30Wqh1O5mCgaDf1b5hB/fnIaLK5wWoPGrWxQ7ls3xwtT1UgP/4E2xSE7LZN7byoWEuJxzBBUm1m5vFFL1RDYDWDdyX9RjYSi78a5jaq5edKiv3BRpZ7PaYBZO2bAjVQWp1ZDRYjMtpRPoAV0Wr5g+ywsMb7995UxLXjhSrCM+Q2QM/OvEdLUrQn/gr2gxGjYZXE/4xV79nWi8M2uTAzaEu2XFnPty/QWlYGJ1ce6RPGtj/h+xZvoPKFWsY6HdWCZZhCpKGtyVv7ASr7U4dZojuFMRghMwissDC26SPG8n2cgHn5wYRpNJmT2ZOWepn7gWGQQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EZQr/M6ZAGtdkHdtU/yOheOT1zuu0vqH3U0KoCJUxLxIaLDc5v5Xrur1IArLHtv1gakVI216F/USamuJwZW9uUF9QGVmu8UWeN+9q548W0ySeEUyiLTzpGDRkuToBRucK+igoepaHW8jwkgSjTEMvu0RBJL4nEX7+kxnwRNEzuXzOI5IEkBe7ip9HYEfWRzNZ4jT2aW12/Yge/5hNRU0j6HbdCQ63hO+ZOvxVRMB+y8+gYjOfU/vgu0lZlf6XFRP4oU6sl5214zQ8IGOwmbB24qlH3ZjbVYbpVgFnhOWi5bcIUVhayRqD+IgF+0JDBqFRZH+tWf3YUSxxYBc+tCMgw==
  • Delivered-to: rdf4j-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/rdf4j-dev/>
  • List-help: <mailto:rdf4j-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/rdf4j-dev>, <mailto:rdf4j-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/rdf4j-dev>, <mailto:rdf4j-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHZiyxW84CA2lCOtEeUbvzUU2xOZa9jQfgAgAAEjgCAADcUsA==
  • Thread-topic: [rdf4j-dev] Breaking change in latest minor release (4.3.0)?

Hmz, existing code should still work, the idea is to deprecate the settings in the helper packages (to be removed in 5.0),

and move them to parser-specific ones

 

Bart

 

From: rdf4j-dev <rdf4j-dev-bounces@xxxxxxxxxxx> On Behalf Of Erik Godding Boye
Sent: zaterdag 20 mei 2023 17:19
To: rdf4j developer discussions <rdf4j-dev@xxxxxxxxxxx>
Subject: Re: [rdf4j-dev] Breaking change in latest minor release (4.3.0)?

 

It seems like the classes are duplicated, and I think the relevant changes are in this PR: https://github.com/eclipse/rdf4j/pull/4332

 

No compiler error, but one of our tests were failing with the following error:

 

30261 [ERROR] verifyDatatypeReasoning  Time elapsed: 0.026 s  <<< ERROR!
java.lang.ClassCastException: class org.eclipse.rdf4j.rio.helpers.JSONLDMode cannot be cast to class org.eclipse.rdf4j.rio.jsonld.JSONLDMode (org.eclipse.rdf4j.rio.helpers.JSONLDMode and org.eclipse.rdf4j.rio.jsonld.JSONLDMode are in unnamed module of loader 'app')
at no.statnett.rdf4j.rio.DatatypeReasonerRDFHandlerTest.verifyDatatypeReasoning(DatatypeReasonerRDFHandlerTest.java:54)

 

On Sat, May 20, 2023 at 5:03 PM Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:

It’s a bit hard to read the diff in an email, but it looks like a package has moved?

-import org.eclipse.rdf4j.rio.helpers.JSONLDMode;
-import org.eclipse.rdf4j.rio.helpers.JSONLDSettings;
+import org.eclipse.rdf4j.rio.jsonld.JSONLDMode;
+import org.eclipse.rdf4j.rio.jsonld.JSONLDSettings;

Håvard

> On 20 May 2023, at 16:52, Erik Godding Boye <egboye@xxxxxxxxx> wrote:
>
> 
> Hi all,
>
> In one of our projects, I had to modify code upgrading to rdf4j 4.3.0, see the patch below.
> Is that expected? It appears like a breaking change to me. 🤔
>
> Erik
>
> Subject: [PATCH] chore: upgrade rdf4j to version 4.3.0
>
> ---
>  pom.xml                                            | 2 +-
>  src/test/java/no/statnett/rdf4j/utils/Writers.java | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/pom.xml b/pom.xml
> index d04aba1..ff31423 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -19,7 +19,7 @@
>      <properties>
>          <spring-boot.version>2.7.12</spring-boot.version>
>          <graphdb.version>10.2.1</graphdb.version>
> -        <rdf4j.version>4.2.4</rdf4j.version>
> +        <rdf4j.version>4.3.0</rdf4j.version>
>          <cxf.version>3.6.0</cxf.version>
> 
>          <graphdb.dist.folder>${project.build.directory}/graphdb-${graphdb.version}</graphdb.dist.folder>
> diff --git a/src/test/java/no/statnett/rdf4j/utils/Writers.java b/src/test/java/no/statnett/rdf4j/utils/Writers.java
> index fe450ab..03a2091 100644
> --- a/src/test/java/no/statnett/rdf4j/utils/Writers.java
> +++ b/src/test/java/no/statnett/rdf4j/utils/Writers.java
> @@ -4,8 +4,8 @@
>  import org.eclipse.rdf4j.rio.RDFWriter;
>  import org.eclipse.rdf4j.rio.Rio;
>  import org.eclipse.rdf4j.rio.helpers.BasicWriterSettings;
> -import org.eclipse.rdf4j.rio.helpers.JSONLDMode;
> -import org.eclipse.rdf4j.rio.helpers.JSONLDSettings;
> +import org.eclipse.rdf4j.rio.jsonld.JSONLDMode;
> +import org.eclipse.rdf4j.rio.jsonld.JSONLDSettings;
> 
>  import java.net.URISyntaxException;
> 
> --
> _______________________________________________
> rdf4j-dev mailing list
> rdf4j-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev
_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev

Back to the top