Re: [platform-dev] Has the time come?

[Sebastian Zarnekow <sebastian.zarnekow@xxxxxxxxx>]

Looking at the https://github.com/eclipse/lemminx-maven/pull/205 I don't see the comments *on* the previous commit that became obsolete due to a force push. I can still see them as outdated in the linear conversation though. This is also the case on Gitlab though. So the force-push habit (which is inherently necessary if FF-only merges are allowed) has an impact on the way we can associate comments with versions of a patch-set.

On Tue, Mar 16, 2021 at 10:34 AM Mickael Istria <mistria@xxxxxxxxxx> wrote:

The _major_ difference is that GitLab supports Gerrit-like review
workflow: it preserves force pushed merge request versions and
comments on them, while GitHub doesn't.

That is not true anymore (it did change about 2 years ago IIRC).

See for instance https://github.com/eclipse/lemminx-maven/pull/205 , several versions of 1 commit, with forced-push, all the versions of the commit remain visible by clicking the references on the line saying `... forced-push ...`, and the comments against previous commits do remain visible in history.

--

Mickael Istria

Eclipse IDE developer, for Red Hat Developers

_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev