Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mylyn-dev] [egit-dev] Moving the EGit Mylyn connector (Was: Re: Not an active committer)
Thanks, Lorenzo.

On Sun, 19 Mar 2023 at 18:08, Lorenzo Bettini <lorenzo.bettini@xxxxxxxxx> wrote:
I mean m2e pde 

Il Dom 19 Mar 2023, 18:07 Lorenzo Bettini <lorenzo.bettini@xxxxxxxxx> ha scritto:
You need to install m2e per to be able to use Maven repos in the target platform 

Il Dom 19 Mar 2023, 11:29 Frank Becker (Eclipse) <eclipse@xxxxxxxxxxxxxxx> ha scritto:
Hi,

Actual we use https://repo.eclipse.org/content/repositories/egit-releases to fetch org.eclipse.egit.github.core via m2 in our target platform.

Here the part from mylyn-e4.26.target

<location includeDependencyDepth="infinite" includeDependencyScopes="compile,provided,runtime" includeSource="true" missingManifest="generate" type="Maven">

<dependencies>

<dependency>

<groupId>org.eclipse.mylyn.github</groupId>

<artifactId>org.eclipse.egit.github.core</artifactId>

<version>6.1.0.202203080745-r</version>

<type>jar</type>

</dependency>

</dependencies>

<repositories>

<repository>

<id>eclipse-egit</id>

<url>https://repo.eclipse.org/content/repositories/egit-releases/</url>

</repository>

</repositories>

<instructions><![CDATA[

Bundle-Name: Bundle derived from maven artifact ${mvnGroupId}:${mvnArtifactId}:${mvnVersion}

version: ${version_cleanup;${mvnVersion}}

Bundle-SymbolicName: ${mvnGroupId}.${mvnArtifactId}

Bundle-Version: ${version}

Import-Package: *;resolution:=optional

Export-Package: *;version="${version}";-noimport:=true

DynamicImport-Package: *

]]></instructions>

</location>


Regards
Frank


Am 19.03.2023 um 09:06 schrieb Matthias Sohn <matthias.sohn@xxxxxxxxx>:

It's deployed on repo.eclipse.org


I plan to move it into the egit repository and add it to its build.
This will allow us to archive the egit-github repository.

-Matthias

On Sat, Mar 18, 2023 at 3:28 PM Wim Jongman <wim.jongman@xxxxxxxxx> wrote:

On Sat, 18 Mar 2023 at 15:21, Wim Jongman <wim.jongman@xxxxxxxxx> wrote:
If we do not include org.eclipse.egit.github.core, where can we consume it from?

Thomas wrote:

This PR also copies org.eclipse.egit.github.core, which is **not** part
of the Mylyn connector. It is a completely separate thing and does not
depend on Mylyn or EGit at all.

Cheers, Wim

On Thu, 12 Jan 2023 at 21:53, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:
Ok, let's do it like Thomas said here.

On Sat, Jan 7, 2023 at 9:35 AM Thomas Wolf <twolf@xxxxxxxxxx> wrote:
On 06.01.23 22:19 , Matthias Sohn wrote:
> We didn't yet discuss in the EGit project if we want to take up
> maintenance again
> since Mylyn is revived or if we hand it over to the Mylyn project.
>
> @EGit committers: what do you think?

Sure, if Mylyn wants to maintain and improve it, that's perfectly fine
with me. We never did much with it. I think the only new development in
the past couple of years in the Mylyn connector was my changing the
repository set-up dialog to support GitHub PATs better.

However, see below:
* Keep org.eclipse.egit.github.core where it currently is; don't move
   that one to Mylyn.
* Also move org.eclipse.egit.mylyn.ui to Mylyn.

> On Fri, Jan 6, 2023 at 3:46 PM Wim Jongman <wim.jongman@xxxxxxxxx
> <mailto:wim.jongman@xxxxxxxxx>> wrote:
>
>     Matthias, we are moving the EGit GitHub connector into Mylyn. WDYT?
>
>     PR is here:
>     https://github.com/eclipse-mylyn/org.eclipse.mylyn/pull/38
>     <https://github.com/eclipse-mylyn/org.eclipse.mylyn/pull/38>
>

This PR also copies org.eclipse.egit.github.core, which is **not** part
of the Mylyn connector. It is a completely separate thing and does not
depend on Mylyn or EGit at all.

I would prefer that one to stay where it is, in the
org.eclipse.egit.github repository. Reasons:

1. It is independent.
2. It uses a BREE of JAVA 8 for Android compatibility.
3. It should be versioned, built, tested, and published independently.

In particular it should be published to maven central.

Some technical things:

The connector makes use of EGit internal classes. EGit has removed it
from x-friends in MANIFEST.MF. Expect a lot of PDE warnings about
discouraged accesses.

I would expect that these accesses to internal classes would be analyzed
and be removed eventually. We'd have to figure out what stable APIs EGit
core and UI would have to provide instead.

EGit does not guarantee anything about internal classes.

Bundle org.eclipse.egit.mylyn.ui, which was removed in the EGit
repository in commit 12a21a6c, should probably also be moved to Mylyn.

There, too, we have internal accesses.

Cheers,

   Thomas



_______________________________________________
egit-dev mailing list
egit-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/egit-dev
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev

_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev
_______________________________________________
mylyn-dev mailing list
mylyn-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/mylyn-dev

Back to the top