Re: [jgit-dev] JGit and GC: why loose refs directories are left behind?

[Luca Milanesio <luca.milanesio@xxxxxxxxx>]

On 7 Jul 2018, at 00:01, Luca Milanesio <luca.milanesio@xxxxxxxxx> wrote:

On 6 Jul 2018, at 23:55, Luca Milanesio <Luca.Milanesio@xxxxxxxxx> wrote:

On 6 Jul 2018, at 23:52, Jonathan Nieder <jrn@xxxxxxxxxx> wrote:

Hi,

Luca Milanesio wrote:

What I've noticed is that JGit does not remove the directories of the loose refs.

Example:
refs/changes/12/162392/01 gets packed in packed-refs *BUT* leave behind the refs/changes/12/162392 directory.

[...] 

Does anybody know why JGit is behaving in that way?

No particularly good reason. :) A bug report (using the "File a Bug" link at http://www.eclipse.org/jgit/support/), or even better, a fix, would be welcome.

Good will do both:

1. Bug raised

https://bugs.eclipse.org/bugs/show_bug.cgi?id=536777

2. Proposed fix for 1.

Working on it ...

Fixed with the three changes in chain:

https://git.eclipse.org/r/c/125755/

Even the fix made by Hector doesn't work properly: I've proposed a fix of his fix to make it work :-)

Tested on JGit 4.7 (Gerrit 2.14) and JGit 4.9 (Gerrit 2.15)

Luca.

On a local filesystem, it slows down, but not that much. On a remote filesystem (e.g., NFS) the slowdown is *very noticeable*

Thanks,

Jonathan