Re: [jgit-dev] fixing bug 321502 - lost in polymorphia

[Matthias Sohn <matthias.sohn@xxxxxxxxxxxxxx>]

2010/8/15 Alex Blewitt <alex.blewitt@xxxxxxxxx>

On 13 Aug 2010, at 23:45, Shawn Pearce <spearce@xxxxxxxxxxx> wrote:

> 3)  We admit that RevObject overridding .equals() is wrong and back
> out that implementation.

Doesn't that break the transitivity of the equals relation in any case? If so, backing out that change would probably be a good idea.

The current equals implementation is also not symmetric across the type hierarchy, e.g.

with

AnyObjectId o1 = ...

RevObject o2 = ...  

o1.equals(o2) may be different from o2.equals(o1)

Pushed http://egit.eclipse.org/r/#change,1313 to fix this.

-- 
Matthias