[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jca-dev] [jakartaee-tck-dev] Connector TCK test deployment failures after updating from connector_1_0.dtd to connector_2_0.xsd
|
On 8/27/20 5:07 PM, Steve Millidge (Payara) wrote:
I have removed the old descriptors from the connectors spec document and we don't have backwards compatibility as a requirement for Jakarta EE 9 so I'd be in favour of removing the old compatibility tests. Let's wait a few days to see if others on the spec dev group also have an opinion on this.
I started looking at what it means to remove the old 1.0 tests, one
impact is that the
internal/docs/connector/jca_1.7/spec/tests-to-ids.html +
internal/docs/connector/jca_1.7/spec/ids-to-tests.html need to be
regenerated after the Connector 1.0 compatibility tests are removed.
Even if we have to regenerate these index files anyway, we would need to
coordinate removing the 1.0 compat tests first.
In summary, the options could be:
1. Remove the 1.0 compat tests, IMO this is the best option, even
though it could take a few more days to nail down for
https://github.com/eclipse-ee4j/jakartaee-tck/pull/474.
2. Update the 1.0 compat tests to use
https://jakarta.ee/xml/ns/jakartaee/connector_2_0.xsd or
http://www.oracle.com/webfolder/technetwork/jsc/xml/ns/javaee/connector_1_7.xsd,
IMO this assumes there is value in keeping the compatibility tests that
use the latest (or previous Jakarta EE release) schema. I don't see the
point of doing this but perhaps others will speak up on this.
Any further feedback on choosing #1 or #2? I think we should get
started on the TCK changes so please do speak up today if you have input
or know of someone that will have input.
Scott
Steve
-----Original Message-----
From: Scott Marlow <smarlow@xxxxxxxxxx>
Sent: 27 August 2020 20:15
To: Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>; jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>
Cc: jca-dev@xxxxxxxxxxx
Subject: Re: [jakartaee-tck-dev] Connector TCK test deployment failures after updating from connector_1_0.dtd to connector_2_0.xsd
Steve,
Related to the earlier questions about spec-version, the files in question appear to need more than just removing the spec-version. The below source files are part of the testing of old connector versions (I think from the first connector version).
Should we remove tests for Connector 1.0 that use the old-whitebox*.rars? I think that the Jakarta Connectors team should help make the decision on this.
Relevant source files:
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-notx-param.xml
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-notx.xml
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-tx-param.xml
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-tx.xml
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-xa-param.xml
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-xa.xml
If we remove the above files, we will need to also remove the test RARs and update Platform + Connector TCK doc:
- old-dd-whitebox-notx-param.rar
- old-dd-whitebox-xa-param.rar
- old-dd-whitebox-tx.rar
- old-dd-whitebox-notx.rar
- old-dd-whitebox-xa.rar
- old-dd-whitebox-tx-param.rar
Since only the previous Jakarta EE version deployment descriptors will be supported (see https://github.com/eclipse-ee4j/jakartaee-platform/pull/236), I think we should delete the old Connector 1.0 compatibility resource archives (as per https://github.com/eclipse-ee4j/jakartaee-platform/pull/236).
Scott
On 8/27/20 12:19 PM, Steve Millidge (Payara) wrote:
I don’t think the connector team have changed the schema. That schema
was likely changed in bulk to the new namespace.
From a quick search the connector 1.6 xsd does not have the
spec-version element.
