Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jca-dev] [jakartaee-tck-dev] Connector TCK test deployment failures after updating from connector_1_0.dtd to connector_2_0.xsd



On 8/26/20 4:44 AM, Steve Millidge (Payara) wrote:
I've had a quick check and commented on the issue;

https://github.com/eclipse-ee4j/jakartaee-tck/pull/474

To summarise the issue seems to be a classloading issue and the exception is thrown after doing a Class.forName on the class specified. Therefore this isn't being thrown from a schema check.

Steve, thanks for checking!

Since the only change that we made was to update from the connector_1_0.dtd to connector_2_0.xsd, I am guessing that we need to make additional changes in the https://github.com/eclipse-ee4j/jakartaee-tck/blob/6be543f6f5fdf62a7189e0570c5c80b4df0360a9/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-tx.xml

Although, I'm not sure which setting would likely be causing the Class.forName to fail on the specified class ("com.sun.ts.tests.common.connector.whitebox.TSConnectionFactory").

Some settings in the ra-compat-tx.xml that look like they could be updated:

1. <spec-version>1.0</spec-version> which is not present in connector_2_0.xsd. I'm guessing that we should remove the spec-version from ra-compat-tx.xml and see if that has any impact.

2. <version>1.6</version> should matter as that is supposed to be the version of the connector resource adapter.

Any recommendations for what we should try updating in https://github.com/eclipse-ee4j/jakartaee-tck/blob/6be543f6f5fdf62a7189e0570c5c80b4df0360a9/src/com/sun/ts/tests/common/connector/whitebox/ra-compat-tx.xml

Scott


Steve

-----Original Message-----
From: jakartaee-tck-dev-bounces@xxxxxxxxxxx <jakartaee-tck-dev-bounces@xxxxxxxxxxx> On Behalf Of Scott Marlow
Sent: 26 August 2020 00:27
To: jakartaee-tck-dev@xxxxxxxxxxx
Cc: jca-dev@xxxxxxxxxxx
Subject: Re: [jakartaee-tck-dev] Connector TCK test deployment failures after updating from connector_1_0.dtd to connector_2_0.xsd

Adding Jakarta Connectors ml...

On 8/25/20 4:54 PM, Scott Marlow wrote:
Hi,

If the connector tests are failing due to connector_1_0.dtd [1] being
less strict than connector_2_0.xsd [2] about the
`connection-interface` type, should the TCK connector tests adjust for
the stricter connector_2_0.xsd [2] requirement that
`connection-interface` be of type "jakartaee:fully-qualified-classType"?

Does connector_2_0.xsd  require the `connection-interface` class to be
in the jakarta namespace?

The test failure is mentioned in jakartaee-tck/pull#474 [3] (see
second paragraph in comment) and also in test result [4].

Connector 2.0 spec [5] shows that connection-interface could be at
least one of { jakarta.resource.cci.Connection,
jakarta.jms.QueueConnection, jakarta.jms.TopicConnection, jakarta.jms.Connection }.

So perhaps the connector TCK tests should update
`com.sun.ts.tests.common.connector.whitebox.TSConnectionFactory` to be
of type jakarta.resource.cci.Connection.

For reference [6] shows the pull/474 ([3])
connector/whitebox/ra-compat-tx.xml file that may need more changes.

Scott

[1] http://java.sun.com/dtd/connector_1_0.dtd
[2] https://jakarta.ee/xml/ns/jakartaee/connector_2_0.xsd
[3]
https://github.com/eclipse-ee4j/jakartaee-tck/pull/474#issuecomment-68
0238740
[4]
https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-alw/job/pr%252F
474/2/testReport/com.sun.ts.tests.connector.connManager/connManagerCli
ent1/jakartaeetck_run___connector___testTransactionSupportLevels_from_
jsp
[5]
https://jakarta.ee/specifications/connectors/2.0/connectors-spec-2.0-R
C2.html
[6]
https://github.com/eclipse-ee4j/jakartaee-tck/blob/6be543f6f5fdf62a718
9e0570c5c80b4df0360a9/src/com/sun/ts/tests/common/connector/whitebox/r
a-compat-tx.xml

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev




Back to the top