Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] update on Jakarta EE 9.1 + SigTest changes

pull/720 [4] updates the Platform TCK `sigtest.jar` to include the [2] pull request and solves the objective of not relying on JDK signatures for SPEC API signature verification.  We made the minimal amount of code changes to implement this via [2].  We deleted the Java SE11 signature map files and used the Java SE8 signature map files in testing on JDK 8, 11, 16, 17 (early access).  We saw many failures that we addressed via [2].  We also verified that signature testing ensures that no SPEC API super/sub setting occurs.

I created a CQ (contribution questionnaire) for the sigtest.jar change that has not yet completed.  As we are looking to finish our Platform TCK changes by Friday (April 16) we also will need some reviews of this change so that it can be merged.  Who will be the first to find the typo in [4]?  I'm kidding about there being a typo but there may be more than one.  :-)

Thanks,
Scott

[4] https://github.com/eclipse-ee4j/jakartaee-tck/pull/720

On 4/9/21 1:48 PM, Scott Marlow wrote:

Hi,

I finished testing the fix [1] change using WildFly (using JDK 11, 16, 17 early release) and passed (see comment with summary of testing on [1] which also describes GlassFish testing)!  The pending pull request [2] has not yet been merged.  Since `jtulach/netbeans-apitest` is already used by other Eclipse projects, I should be able to file a CQ that piggy backs on another CQ for bring the `jtulach/netbeans-apitest` produced `sigtest` fork into the Platform TCK project.

If [2] doesn't get merged in time for Jakarta EE 9.1, we could consider tagging a release off of https://github.com/scottmarlow/netbeans-apitest/tree/sigtest_netbeans-script-part2, hopefully that won't be needed but we should still consider that.

Once we have `sigtest` jars that include [2], we can create a Jakarta EE Platform TCK pull request that includes the [3] branch changes.

Solving [1] will allow EE implementations to be able to run TCK signature tests on later JDK releases using signature map files written for the base JDK version (e.g. JDK 8 for Jakarta EE 9.1).  We also will only need a set of signature files for the base JDK version (e.g. se11 signature map files are removed from [3]).

Scott

[1] https://github.com/eclipse-ee4j/jakartaee-tck/issues/156
[2] https://github.com/jtulach/netbeans-apitest/pull/2
[3] https://github.com/scottmarlow/jakartaee-tck/tree/sigtest_netbeans-script-part2

Back to the top